refactor: get_action_helpstr parse action dict

Author: phanen

lua/fzf-lua/config.lua

@@ -1063,8 +1063,14 @@ M.set_action_helpstr = function(fn, helpstr)
   M._action_to_helpstr[fn] = helpstr
 end
 
-M.get_action_helpstr = function(fn)
-  return M._action_to_helpstr[fn]
+---@param v fzf-lua.ActionSpec|any
+---@return string
+M.get_action_helpstr = function(v)
+  local t = M._action_to_helpstr
+  if type(v) ~= "table" or t[v] then return t[v] or tostring(v) end
+  local res = v.desc or t[v[1]] or t[v.fn] or v.header
+  if res then return res end
+  return type(v[1]) == "string" and v[1] or tostring(v)
 end
 
 M._action_to_helpstr = {

lua/fzf-lua/core.lua

@@ -1020,7 +1020,7 @@ M.convert_reload_actions = function(reload_cmd, opts)
           M.can_transform(opts) and "transform" or "reload", -- contents is not "cmd" but "reload:cmd"
           reload_cmd,
           type(v.postfix) == "string" and v.postfix or ""),
-        desc = v.desc or config.get_action_helpstr(v.fn)
+        desc = config.get_action_helpstr(v)
       }
     end
   end
@@ -1075,7 +1075,7 @@ M.convert_exec_silent_actions = function(opts)
           or string.format(":%s", cmd),
           -- can't use postfix since we use "execute-silent:..."
           has_fzf036 and type(v.postfix) == "string" and v.postfix or ""),
-        desc = v.desc or config.get_action_helpstr(v.fn)
+        desc = config.get_action_helpstr(v)
       }
     end
   end

lua/fzf-lua/profiles/hide.lua

@@ -73,7 +73,7 @@ return {
         then
           local fn = act.fn
           act.exec_silent = true
-          act.desc = act.desc or fzf.config.get_action_helpstr(fn)
+          act.desc = act.desc or fzf.config.get_action_helpstr(act)
           act.fn = function(...)
             fzf.hide()
             if fn then fn(...) end

lua/fzf-lua/types.lua

@@ -55,6 +55,7 @@ local FzfLua = require("fzf-lua")
 ---@field reload? boolean
 ---@field field_index? string
 ---@field desc? string
+---@field header? string|false
 ---@field prefix? string
 ---@field postfix? string
 ---@field reuse? boolean

lua/fzf-lua/win/help.lua

@@ -47,43 +47,26 @@ function M.toggle(keymap, actions, hls, zindex, preview_keymaps, preview_mode, h
   for _, m in ipairs({ "builtin", "fzf" }) do
     for k, v in pairs(keymap[m]) do
       if not keymap_ignore[k] then
-        -- value can be defined as a table with addl properties (help string)
-        if type(v) == "table" then
-          v = v.desc or v[1]
-        end
+        v = config.get_action_helpstr(v)
         -- only add preview keybinds respective of
         -- the current preview mode
-        if v and (not preview_keymaps[v] or m == preview_mode) then
+        if not preview_keymaps[v] or m == preview_mode then
           if m == "builtin" then
             k = utils.neovim_bind_to_fzf(k)
           end
-          v = type(v) == "function" and config.get_action_helpstr(v) or tostring(v)
           table.insert(keymaps,
             format_bind(m, k, v, opts.mode_width, opts.keybind_width, opts.name_width))
         end
       end
     end
   end
 
-  ---TODO: we can always parse the action into table to avoid this duplicated logic
-  ---(e.g. profile/hide.lua, config.lua)
-  ---@param v fzf-lua.ActionSpec
-  ---@return string?
-  local get_desc = function(v)
-    if type(v) == "table" then
-      return v.desc or config.get_action_helpstr(v[1]) or config.get_action_helpstr(v.fn) or
-          v.header or tostring(v)
-    elseif v then
-      return config.get_action_helpstr(v) or tostring(v)
-    end
-  end
-
   -- action keymaps
   if actions then
     for k, v in pairs(actions) do
       if v then -- skips 'v == false'
         if k == "default" then k = "enter" end
-        local desc = get_desc(v)
+        local desc = config.get_action_helpstr(v)
         table.insert(keymaps,
           format_bind("action", k,
             ("%s"):format(desc):gsub(" ", ""),