fix(live): use fzf start event

chore: deprecate fzf < 0.35, should be ok, it's been out since Nov 2022

Author: ibhagwan

README.md

@@ -56,7 +56,7 @@ Using [lazy.nvim](https://github.com/folke/lazy.nvim)
 ### Dependencies
 
 - [`neovim`](https://github.com/neovim/neovim/releases) version >= `0.9`
-- [`fzf`](https://github.com/junegunn/fzf) version > `0.25`
+- [`fzf`](https://github.com/junegunn/fzf) version > `0.35`
   or [`skim`](https://github.com/skim-rs/skim) binary installed
 - [nvim-web-devicons](https://github.com/nvim-tree/nvim-web-devicons)
   or [mini.icons](https://github.com/echasnovski/mini.icons)

doc/fzf-lua.txt

@@ -1,4 +1,4 @@
-*fzf-lua.txt*           For Neovim >= 0.9.0          Last change: 2025 June 28
+*fzf-lua.txt*           For Neovim >= 0.9.0          Last change: 2025 July 12
 
 ==============================================================================
 Table of Contents                                  *fzf-lua-table-of-contents*
@@ -100,7 +100,7 @@ Using lazy.nvim <https://github.com/folke/lazy.nvim>
 DEPENDENCIES                                            *fzf-lua-dependencies*
 
 - `neovim` <https://github.com/neovim/neovim/releases> version >= `0.9`
-- `fzf` <https://github.com/junegunn/fzf> version > `0.25` or `skim`
+- `fzf` <https://github.com/junegunn/fzf> version > `0.35` or `skim`
   <https://github.com/skim-rs/skim> binary installed
 - nvim-web-devicons <https://github.com/nvim-tree/nvim-web-devicons> or
   mini.icons <https://github.com/echasnovski/mini.icons> (optional)
@@ -1146,7 +1146,7 @@ CUSTOMIZATION                                          *fzf-lua-customization*
       },
       quickfix = {
         file_icons        = true,
-        only_valid        = false, -- select among only the valid quickfix entries
+        valid_only        = false, -- select among only the valid quickfix entries
       },
       quickfix_stack = {
         prompt = "Quickfix Stack> ",
@@ -1624,4 +1624,4 @@ I missed your name feel free to contact me and I'll add it below:
   previewer code while using nvim-bqf
   <https://github.com/kevinhwang91/nvim-bqf>
 
-vim:tw=78:ts=8:ft=help:norl:
+vim:tw=78:ts=8:ft=help:norl:

lua/fzf-lua/config.lua

@@ -671,8 +671,8 @@ function M.normalize_opts(opts, globals, __resume_key)
     if not opts.__FZF_VERSION then
       utils.err(string.format("'fzf --version' failed with error %s: %s", rc, err))
       return nil
-    elseif not utils.has(opts, "fzf", { 0, 25 }) then
-      utils.err(string.format("fzf version %s is lower than minimum (0.25), aborting.",
+    elseif not utils.has(opts, "fzf", { 0, 35 }) then
+      utils.err(string.format("fzf version %s is lower than minimum (0.35), aborting.",
         utils.ver2str(opts.__FZF_VERSION)))
       return nil
     end

lua/fzf-lua/core.lua

@@ -175,8 +175,7 @@ M.fzf_live = function(contents, opts)
   opts.fn_reload = shell.stringify(contents, opts)
   local fzf_field_index = M.fzf_field_index(opts)
   local cmd = M.expand_query(opts.fn_reload, fzf_field_index)
-  opts = M.setup_fzf_interactive_flags(cmd, fzf_field_index, opts)
-  contents = opts.__fzf_init_cmd
+  contents, opts = M.setup_fzf_interactive_flags(cmd, fzf_field_index, opts)
   return M.fzf_wrap(contents, opts)
 end
 
@@ -192,7 +191,7 @@ M.fzf_resume = function(opts)
   opts = M.set_header(opts, opts.headers or {})
   opts.cwd = opts.cwd and libuv.expand(opts.cwd) or nil
   opts.__resuming = true
-  M.fzf_exec(config.__resume_data.contents, config.__resume_data.opts)
+  M.fzf_wrap(config.__resume_data.contents, config.__resume_data.opts)
 end
 
 ---@param contents string?
@@ -1148,7 +1147,7 @@ end
 ---@param command string
 ---@param fzf_field_index string
 ---@param opts table
----@return table
+---@return string?, table
 M.setup_fzf_interactive_flags = function(command, fzf_field_index, opts)
   -- query cannot be 'nil'
   opts.query = opts.query or ""
@@ -1190,8 +1189,6 @@ M.setup_fzf_interactive_flags = function(command, fzf_field_index, opts)
       )
 
   if opts._is_skim then
-    -- skim interactive mode does not need a piped command
-    opts.__fzf_init_cmd = nil
     opts.prompt = opts.__prompt or opts.prompt or opts.fzf_opts["--prompt"]
     if opts.prompt then
       opts.fzf_opts["--prompt"] = opts.prompt:match("[^%*]+")
@@ -1215,10 +1212,6 @@ M.setup_fzf_interactive_flags = function(command, fzf_field_index, opts)
     opts._fzf_cli_args = string.format("--interactive --cmd %s",
       libuv.shellescape(no_query_condi .. reload_command))
   else
-    -- **send an empty table to avoid running $FZF_DEFAULT_COMMAND
-    -- The above seems to create a hang in some systems
-    -- use `true` as $FZF_DEFAULT_COMMAND instead (#510)
-    opts.__fzf_init_cmd = utils.shell_nop()
     if opts.exec_empty_query or (opts.query and #opts.query > 0) then
       local q = not utils.__IS_WINDOWS and opts.query
           or libuv.escape_fzf(opts.query, utils.has(opts, "fzf", { 0, 52 }) and 0.52 or 0)
@@ -1234,9 +1227,20 @@ M.setup_fzf_interactive_flags = function(command, fzf_field_index, opts)
     end
     opts._fzf_cli_args = string.format("--bind=%s", libuv.shellescape(
       string.format("change:reload:%s%s", no_query_condi, reload_command)))
+    if utils.has(opts, "fzf", { 0, 35 }) then
+      opts._fzf_cli_args = opts._fzf_cli_args .. string.format(" --bind=%s",
+        libuv.shellescape(string.format("start:reload:%s%s", no_query_condi, reload_command)))
+      -- NOTE: not needed since we deprecated fzf < v0.35
+      -- elseif opts.exec_empty_query or (opts.query and #opts.query > 0) then
+      --   local q = not utils.__IS_WINDOWS and opts.query
+      --       or libuv.escape_fzf(opts.query, utils.has(opts, "fzf", { 0, 52 }) and 0.52 or 0)
+      --   -- gsub doesn't like single % on rhs
+      --   local escaped_q = libuv.shellescape(q):gsub("%%", "%%%%")
+      --   opts.__fzf_init_cmd = initial_command:gsub(fzf_field_index, escaped_q)
+    end
   end
 
-  return opts
+  return utils.shell_nop(), opts
 end
 
 -- query placeholder for "live" queries