chore(luals): remove need-check-nil

Author: phanen

.luarc.jsonc

@@ -25,7 +25,7 @@
       "unbalanced": "Opened",
       "unused": "Opened"
     },
-    "disable": ["need-check-nil", "different-requires"],
+    "disable": ["different-requires"],
     "unusedLocalExclude": ["_*"]
   },
   "workspace": {

lua/fzf-lua/config.lua

@@ -76,6 +76,7 @@ M.globals = setmetatable({}, {
     local setup_default = utils.map_get(setup_defaults(), index)
     local setup_value = utils.map_get(setup_opts(), index)
     local function build_bind_tables(keys)
+      assert(fzflua_default)
       -- bind tables are logical exception, do not merge with defaults unless `[1] == true`
       -- normalize all binds as lowercase to prevent duplicate keys (#654)
       local ret = {}
@@ -150,7 +151,7 @@ function M.normalize_opts(opts, globals, __resume_key)
 
   -- opts can also be a function that returns an opts table
   if type(opts) == "function" then
-    opts = opts()
+    opts = opts() or {}
   end
 
   local profile = opts.profile or (function()
@@ -202,6 +203,7 @@ function M.normalize_opts(opts, globals, __resume_key)
     -- merge with setup options "defaults" table
     globals = vim.tbl_deep_extend("keep", globals, M.setup_opts.defaults or {})
   end
+  ---@cast globals table
 
   -- merge current opts with revious __call_opts on resume
   if opts.resume then

lua/fzf-lua/core.lua

@@ -821,6 +821,8 @@ M.set_title_flags = function(opts, titles)
 end
 
 M.set_header = function(opts, hdr_tbl)
+  ---@param cwd string
+  ---@return string
   local function normalize_cwd(cwd)
     if path.is_absolute(cwd) and not path.equals(cwd, uv.cwd()) then
       -- since we're always converting cwd to full path

lua/fzf-lua/libuv.lua

@@ -60,8 +60,8 @@ end
 ---@return integer         pid
 M.spawn = function(opts, fn_transform, fn_done)
   local EOL = opts.EOL or "\n"
-  local output_pipe = uv.new_pipe(false)
-  local error_pipe = uv.new_pipe(false)
+  local output_pipe = assert(uv.new_pipe(false))
+  local error_pipe = assert(uv.new_pipe(false))
   local write_cb_count, read_cb_count, on_exit_called = 0, 0, nil
   local prev_line_content = nil
   local handle, pid
@@ -494,7 +494,7 @@ M.spawn_stdio = function(opts, fn_transform_str, fn_preprocess_str, fn_postproce
     if type(fd) ~= "number" then
       exit(1, ("error opening '%s': %s" .. EOL):format(pipename, fd))
     end
-    local pipe = uv.new_pipe(false)
+    local pipe = assert(uv.new_pipe(false))
     pipe:open(fd)
     return pipe
   end

lua/fzf-lua/make_entry.lua

@@ -5,7 +5,7 @@ local path = require "fzf-lua.path"
 local utils = require "fzf-lua.utils"
 local libuv = require "fzf-lua.libuv"
 local devicons = require "fzf-lua.devicons"
-local config = nil
+local config
 
 -- attempt to load the current config
 -- should fail if we're running headless

lua/fzf-lua/path.lua

@@ -134,7 +134,7 @@ end
 function M.normalize(path)
   local p = M.tilde_to_HOME(path)
   if utils.__IS_WINDOWS then
-    p = p:gsub([[\]], [[/]])
+    p = (p:gsub([[\]], [[/]]))
   end
   return p
 end
@@ -243,16 +243,15 @@ M.HOME = function()
   return M.__HOME
 end
 
----@param path string?
----@return string?
+---@param path string
+---@return string
 function M.tilde_to_HOME(path)
-  return path and path:gsub("^~", M.HOME()) or nil
+  return (path:gsub("^~", M.HOME()))
 end
 
----@param path string?
----@return string?
+---@param path string
+---@return string
 function M.HOME_to_tilde(path)
-  if not path then return end
   if utils.__IS_WINDOWS then
     local home = M.HOME()
     if path:sub(1, #home):lower() == home:lower() then
@@ -575,7 +574,8 @@ function M.keymap_to_entry(str, opts)
   if not mode or not keymap then return {} end
   mode, keymap = vim.trim(mode), vim.trim(keymap)
   mode = valid_modes[mode] and mode or "" -- only valid modes
-  local out, vmap, cmd = nil, nil, string.format("verbose %smap %s", mode, keymap)
+  local out
+  local vmap, cmd = nil, string.format("verbose %smap %s", mode, keymap)
   -- Run in the context of the originating buffer or keympas might return
   -- "No mapping found"
   pcall(vim.api.nvim_buf_call, opts.__CTX.bufnr, function()

lua/fzf-lua/previewer/builtin.lua

@@ -995,6 +995,7 @@ function Previewer.base:update_ts_context()
   local lang = vim.treesitter.language.get_lang(ft)
   if not utils.has_ts_parser(lang) then return end
   local parser = vim.treesitter.get_parser(self.preview_bufnr, lang)
+  if not parser then return end
   local context_updated
   TSContext.zindex = self.win.winopts.zindex + 20
   for _, t in ipairs({ 0, 20, 50, 100 }) do

lua/fzf-lua/providers/buffers.lua

@@ -218,9 +218,12 @@ end
 
 M.blines = function(opts)
   opts = config.normalize_opts(opts, "blines")
+  -- TODO: remove this guard
+  if not opts then return end
   opts.current_buffer_only = true
   if utils.mode_is_visual() then
     local _, sel = utils.get_visual_selection()
+    if not sel then return end
     opts.start_line = opts.start_line or sel.start.line
     opts.end_line = opts.end_line or sel["end"].line
   end
@@ -255,6 +258,7 @@ M.buffer_lines = function(opts)
       local bnames = {}
       local longest_bname = 0
       for _, b in ipairs(buffers) do
+        ---@type string
         local bname = utils.nvim_buf_get_name(b)
         if not bname:match("^%[") then
           bname = path.shorten(vim.fn.fnamemodify(bname, ":~:."))
@@ -606,6 +610,7 @@ M.spellcheck = function(opts)
 
   if utils.mode_is_visual() then
     local _, sel = utils.get_visual_selection()
+    if not sel then return end
     opts.start_line = opts.start_line or sel.start.line
     opts.end_line = opts.end_line or sel["end"].line
   end
@@ -655,7 +660,7 @@ M.spellcheck = function(opts)
             return s:gsub("^" .. word_separator .. "+", ""):gsub(word_separator .. "+$", "")
           end
           from, to = string.find(line, "%w+", from)
-          local word = from and string.sub(line, from, to)
+          local word = from and string.sub(line, from, to) or ""
           local prefix = from and string.sub(line, from - 1, from - 1) or ""
           local postfix = to and string.sub(line, to + 1, to + 1) or ""
           local valid_word = word

lua/fzf-lua/providers/colorschemes.lua

@@ -314,7 +314,7 @@ function AsyncDownloadManager:jobstart(plugin, job_args)
   else
     -- job started successfully
     utils.info(string.format("%s [path:%s] [job_id:%d]...",
-      msg, path.HOME_to_tilde(info.path), job_id))
+      msg, path.HOME_to_tilde(assert(info.path)), job_id))
     self.job_ids[tostring(job_id)] = { plugin = plugin, args = job_args }
     self.db[plugin].job_id = job_id
   end

lua/fzf-lua/providers/dap.lua

@@ -5,7 +5,8 @@ local utils = require "fzf-lua.utils"
 local config = require "fzf-lua.config"
 local make_entry = require "fzf-lua.make_entry"
 
-local _has_dap, _dap = nil, nil
+local _has_dap
+local _dap
 
 local M = {}