fix(hide): actions should be nop when nothing match

Regression from f0e830e

e.g. `FzfLua files query=nothing` then `<c-t>` should not open new tab

fix: opts.__pid -> opts.PidObject

Author: phanen

lua/fzf-lua/core.lua

@@ -392,8 +392,9 @@ M.fzf = function(contents, opts)
   -- NOTE: might be an overkill since we're using $FZF_DEFAULT_COMMAND
   -- to spawn the piped process and fzf is responsible for termination
   -- when the fzf process exists
-  if tonumber(opts.__pid) then
-    libuv.process_kill(opts.__pid)
+  if opts.PidObject then
+    libuv.process_kill(opts.PidObject:get())
+    opts.PidObject:set(nil)
   end
   -- If a hidden process was killed by [re-]starting a new picker do nothing
   if fzf_win:was_hidden() then return nil, nil end

lua/fzf-lua/shell.lua

@@ -489,7 +489,6 @@ end
 ---@param field_index string
 ---@return string
 M.stringify_data2 = function(fn, opts, field_index)
-  local field_index0 = field_index
   local did_override = false
   if not field_index:match("{q} {n}$") then
     field_index = field_index .. " {q} {n}"
@@ -506,7 +505,7 @@ M.stringify_data2 = function(fn, opts, field_index)
     -- fix side effect of "{q} {+}": {+} is forced expanded to ""
     -- only when field_index is empty (otherwise it can be complex/unpredictable)
     -- {n} used to determine if "zero-selected && zero-match", then patch: "" -> nil
-    if #field_index0 == 0 then
+    if field_index == "{+} {q} {n}" then
       -- When no item is matching (empty list or non-matching query)
       -- both {n} and {+} are expanded to "".
       -- NOTE1: older versions of fzf don't expand {n} to "" (without match)

tests/files_spec.lua

@@ -87,7 +87,7 @@ T["files"]["previewer"]["builtin"] = new_set({ parametrize = { { "ci" }, { "buil
         -- Verify previewer "last_entry" was set
         child.type_keys("<c-j>")
         child.wait_until(function()
-          return child.lua_get([[FzfLua.utils.fzf_winobj()._previewer.last_entry]]) ==
+          return exec_lua([[return FzfLua.utils.fzf_winobj()._previewer.last_entry]]) ==
               (icons and " LICENSE" or "LICENSE")
         end)
       end,
@@ -187,4 +187,16 @@ T["files"]["preview should work after chdir #1864"] = function()
   })
 end
 
+T["files"]["nop on nothing match"] = function()
+  reload({ "hide" })
+  local ctx = exec_lua([[return FzfLua.utils.CTX()]])
+  for _, key in ipairs({ "<cr>", "<c-t>" }) do
+    exec_lua([[FzfLua.files { query = ("%s is nop on nothing match"):format(...) }]], { key })
+    child.wait_until(function() return exec_lua([[return _G._fzf_load_called]]) == true end)
+    child.type_keys(key)
+    child.wait_until(function() return exec_lua([[return _G._fzf_lua_on_create]]) == vim.NIL end)
+    eq(ctx, exec_lua([[return FzfLua.utils.CTX()]]))
+  end
+end
+
 return T