exclude vim.ui.select from resume state

[sirfz]

I'm sure this already has a solution but I couldn't find anything searching issues/discussions so here goes:

I have vim.ui.select configured to use fzf-lua:

require("fzf-lua").register_ui_select(function(_, items)          
    local min_h, max_h = 0.15, 0.70                               
    local h = (#items + 4) / vim.o.lines                          
    if h < min_h then                                             
        h = min_h                                                 
    elseif h > max_h then                                         
        h = max_h                                                 
    end                                                           
    return { winopts = { height = h, width = 0.60, row = 0.40 } } 
end)                                                              

Say I launch a grep search and then trigger some action that open vim.ui.select, this will overwrite the resume state so I have to restart my grep.

How can vim.ui.select actions be excluded from resume?

[ibhagwan]

Add no_resume to returned options:

return { no_resume = true, winopts = { height = h, width = 0.60, row = 0.40 } } 

[ibhagwan]

I just run my key bind for code actions (<leader>la) which I assume calls vim.lsp.buf.code_actions. Yes, when I resume I just get the code actions picker (ui.select)

I’m assuming you didn’t create the bind since you’re using a distribution which may or may not contain other config code.

Are you sure your register_ui_ select function is called? Can you add a print and test?

[sirfz]

Yes the registration is being called and working correctly however I just tried it with triggering a different picker (in this case, sidekick cli picker) and the resume worked correctly (still showed my previous search instead of the sidekick list). But with vim.lsp.buf.code_actions it would resume code actions instead.

As a workaround, what I did for now is replace <cmd>lua vim.lsp.buf.code_action()<cr> with <cmd>FzfLua lsp_code_actions no_resume=true<cr> as my code actions keymap

[sirfz]

scratch that, that would resume my previous picker but clear the state, is there another workaround?

[ibhagwan]

Yes the registration is being called and working correctly however I just tried it with triggering a different picker (in this case, sidekick cli picker) and the resume worked correctly (still showed my previous search instead of the sidekick list). But with vim.lsp.buf.code_actions it would resume code actions instead.

As a workaround, what I did for now is replace <cmd>lua vim.lsp.buf.code_action()<cr> with <cmd>FzfLua lsp_code_actions no_resume=true<cr> as my code actions keymap

Interesting, I’ll do some more testing when I get a chance

[ibhagwan]

scratch that, that would resume my previous picker but clear the state, is there another workaround?

You can try with any profile that isn’t hide/default (:FzfLua profiles load=border-fused) and see if that helps but as I mentioned somewhere the state won’t be restored perfectly because the fzf process is a singleton so when code actions start the fzf process terminates, that limits the resume to the search/query without the cursor/selection/etc.

There is no workaround for this as fzf-lua will need to manage multiple processes which it currently doesn’t do.

[ibhagwan]

Tested this again, the register_ui_select opts indeed do not affect the lsp code actions, you'd need to add no_resume specifically to lsp.code_actions:

opts  =  {
  ...
  -- your other opts
  lsp = {
    code_actions =  { no_resume = true },
  },
},

[sirfz]

That seems to work but I was already getting the same behavior without. It resumes the picker but the state is gone so not very useful unfortunately

[ibhagwan]

That seems to work but I was already getting the same behavior without. It resumes the picker but the state is gone so not very useful unfortunately

While we cannot restore the full state (cursor/selection) due to original process being replaced a7aac57, this should restore the query/search as if you we re running :FzfLua live_grep resume=true.

[sirfz]

This works perfectly, thank you!