Deeply nested undotree is "hidden"

[igorlfs]

Hello,

I was playing around with the new Undotree picker and I noticed that if I have a really deep tree, fzf-lua is unable to show the graph with the nodes (or rather, it can't show any useful information):

Could these cases be handled somehow? I'm not sure if that's the intended behavior, but, to be fair, I think not much can be done in such circumstances.

Oh, and by the way, I also noticed that if :FzfLua undotree previewer=undotree_native is called when delta isn't installed, this assertion fails. Maybe it could be handled more gracefully?

[ibhagwan]

Maybe :FzfLua undotree fzf_opts.--keep-right=true can help?

Surely I’ll fix the assert, code should never fail like this.

[gennaro-tedesco]

Is something like the below desirable?

namely removing all spurious extra tab/spaces and the references to the sequence numbers?

[ibhagwan]

Is something like the below desirable?

It looks alright, while this alleviates the issue I’m not sure if it would be solve the OP issue completely, what about something similar to the output of :Undotree (added in 0.12) - have you looked at it?

[gennaro-tedesco]

I haven't looked yet at how they do it.

In general however the difference in output comes down to the display of the timestamps format, besides the ascii vs unicode character (which one can choose at preference, but in any case it's one character spacing in either case, be it an ascii symbol or a unicode character).

I’m not sure if it would be solve the OP issue completely

@igorlfs how would your deep nested tree look if you, say, remove the tabs here?

[igorlfs]

Hey folks,

maybe not as default, but offered as collapse=true option that the user may choose, if they don't need to see the graph hierarchy

I'm not sure if having an optional "compact" layout is the ideal solution here. I haven't even used this feature that much, this issue popped up within the first few files when I was giving it a try. Others could run into this problem as well, and having to search the documentation for the parameter that "makes it work" doesn't strike me as good design (given that there's not much downside for going with compact as the default).

I found it a bit confusing to follow the graph with the simple ascii, maybe there are some Unicode chars to make it look nicer?

+1

Is something like the below desirable?

I liked it. Though it looks like there's a slight misalignment for the characters at the bottom?

how would your deep nested tree look if you, say, remove the tabs

With the original file, there's no difference at all:

Edit: I guess that's kinda expected, since we are not changing the indentation?

[ibhagwan]

IMHO the best solution would be a graph similar to the output of :Undotree albeit with Unicode characters which make it easier to read.

[ibhagwan]

@igorlfs, FYI, the incorrect assert was removed in c7ff27d.