Skip to content

fix: XMP sidecar crash resilience, EXIF safety, and timezone-aware fallbacks #1614

fix: XMP sidecar crash resilience, EXIF safety, and timezone-aware fallbacks

fix: XMP sidecar crash resilience, EXIF safety, and timezone-aware fallbacks #1614

Workflow file for this run

name: Quality Checks
on:
push:
branches:
- '**'
pull_request:
workflow_dispatch:
jobs:
skip_check:
runs-on: ubuntu-24.04
outputs:
should_skip: ${{ steps.skip_check.outputs.should_skip }}
steps:
- id: skip_check
uses: fkirc/skip-duplicate-actions@v5
with:
concurrent_skipping: 'same_content_newer'
skip_after_successful_duplicate: 'true'
paths_ignore: '["**/*.md", "examples/**", "docs/**"]'
do_not_skip: '["workflow_dispatch", "schedule"]'
lint:
needs: skip_check
if: needs.skip_check.outputs.should_skip != 'true'
runs-on: ubuntu-24.04
strategy:
matrix:
python-version: ['3.10', '3.11', '3.12', '3.13']
env:
UV_PYTHON: ${{ matrix.python-version }}
steps:
- uses: actions/checkout@v6
- uses: astral-sh/setup-uv@v5
with:
enable-cache: true
- name: Install dependencies
run: uv sync --group test
- name: Lint
run: uv run ruff check --ignore "E402"
type_check:
needs: skip_check
if: needs.skip_check.outputs.should_skip != 'true'
runs-on: ubuntu-24.04
strategy:
matrix:
python-version: ['3.10', '3.11', '3.12', '3.13']
env:
UV_PYTHON: ${{ matrix.python-version }}
steps:
- uses: actions/checkout@v6
- uses: astral-sh/setup-uv@v5
with:
enable-cache: true
- name: Install dependencies
run: uv sync --group test
- name: Type Check
run: uv run python -m mypy src tests --strict --python-version 3.10
patch_version:
needs: skip_check
if: needs.skip_check.outputs.should_skip != 'true'
uses: ./.github/workflows/patch-version.yml
test:
needs: [skip_check, patch_version]
if: needs.skip_check.outputs.should_skip != 'true'
runs-on: ubuntu-24.04
strategy:
matrix:
python-version: ['3.10', '3.11', '3.12', '3.13']
env:
UV_PYTHON: ${{ matrix.python-version }}
steps:
- name: Install system dependencies
run: |
sudo apt-get update && sudo apt-get -y install locales locales-all libimage-exiftool-perl
- uses: actions/checkout@v6
- name: Download version info
uses: actions/download-artifact@v5
with:
name: icloudpd-version-info
path: |
src/foundation
- uses: astral-sh/setup-uv@v5
with:
enable-cache: true
- name: Install dependencies
run: uv sync --group test
- name: Test
run: uv run python -m pytest --cov=icloudpd --cov-report html --cov-report term-missing --numprocesses auto
test_non_linux:
needs: [skip_check, patch_version]
if: needs.skip_check.outputs.should_skip != 'true'
runs-on: ${{ matrix.os }}
defaults:
run:
shell: bash
strategy:
fail-fast: false
matrix:
python-version: [3.13]
os:
- "macos-15"
- "macos-14"
- "windows-2025"
- "windows-2025"
env:
UV_PYTHON: ${{ matrix.python-version }}
steps:
- uses: actions/checkout@v6
- name: Download version info
uses: actions/download-artifact@v5
with:
name: icloudpd-version-info
path: |
src/foundation
- name: Install exiftool
run: |
if [ "$RUNNER_OS" = "macOS" ]; then
brew install exiftool
elif [ "$RUNNER_OS" = "Windows" ]; then
choco install exiftool -y
fi
- uses: astral-sh/setup-uv@v5
with:
enable-cache: true
- name: Install dependencies
run: uv sync --group test
- name: Test
run: uv run python -m pytest --cov=icloudpd --cov-report html --cov-report term-missing --numprocesses auto
get_version:
needs: skip_check
if: needs.skip_check.outputs.should_skip != 'true'
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v6
- name: Retrieve version
id: get_version
run: |
echo icloudpd_version=$(scripts/get_version) >> $GITHUB_OUTPUT
- name: Log version
run: |
echo "icloudpd_version=${{steps.get_version.outputs.icloudpd_version}}"
outputs:
icloudpd_version: ${{steps.get_version.outputs.icloudpd_version}}
extract_changelog:
needs: [get_version, skip_check]
if: needs.skip_check.outputs.should_skip != 'true'
uses: ./.github/workflows/extract-changelog.yml
with:
icloudpd_version: ${{needs.get_version.outputs.icloudpd_version}}