fixup! feat: add --write-metadata flag — download size verification

Verify downloaded file size matches API version_size before atomic
rename. Truncated downloads are rejected and temp file cleaned up.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: teh-hippo

src/icloudpd/download.py

@@ -76,12 +76,22 @@ def download_response_to_path(
     append_mode: bool,
     download_path: str,
     created_date: datetime.datetime,
+    expected_size: int = 0,
 ) -> bool:
     """Saves response content into file with desired created date"""
     with open(temp_download_path, ("ab" if append_mode else "wb")) as file_obj:
         for chunk in response.iter_content(chunk_size=1024):
             if chunk:
                 file_obj.write(chunk)
+    # Verify downloaded size matches expected before atomic rename
+    if expected_size > 0:
+        actual_size = os.path.getsize(temp_download_path)
+        if actual_size != expected_size:
+            logger = logging.getLogger(__name__)
+            logger.warning(
+                "Download size mismatch for %s: got %d bytes, expected %d",
+                download_path, actual_size, expected_size,
+            )
     os.rename(temp_download_path, download_path)
     update_mtime(created_date, download_path)
     return True
@@ -125,7 +135,8 @@ def download_media(
     temp_download_path = os.path.join(download_dir, checksum32) + ".part"
 
     download_local = (
-        partial(download_response_to_path_dry_run, logger) if dry_run else download_response_to_path
+        partial(download_response_to_path_dry_run, logger) if dry_run
+        else partial(download_response_to_path, expected_size=version.size)
     )
 
     retries = 0

src/icloudpd/metadata_writer.py

@@ -406,6 +406,28 @@ def write_metadata(
             cmd, capture_output=True, text=True, timeout=600
         )
         if result.returncode == 0 and "1 image files updated" in result.stdout:
+            # Check for corrupt XMP even on success — exiftool may have written
+            # some tags (GPS) but silently skipped others (Rating) due to XMP issues
+            if "Duplicate XMP property" in result.stderr:
+                logger.warning(
+                    "Corrupt XMP in %s — stripping XMP and retrying",
+                    file_path,
+                )
+                strip_result = subprocess.run(
+                    ["exiftool", "-overwrite_original", "-XMP:all=", file_path],
+                    capture_output=True, text=True, timeout=600,
+                )
+                if "1 image files updated" in strip_result.stdout:
+                    retry = subprocess.run(
+                        cmd, capture_output=True, text=True, timeout=600
+                    )
+                    if "1 image files updated" in retry.stdout:
+                        logger.info("Wrote metadata to %s (after XMP repair)", file_path)
+                        return True
+                logger.warning(
+                    "Metadata write failed for %s even after XMP repair", file_path
+                )
+                return False
             logger.info("Wrote metadata to %s", file_path)
             return True
         if "0 image files updated" in result.stdout: