Skip to content

Commit 34b49da

Browse files
Docs:improve grammar and versioning (#1233)
1 parent 9519784 commit 34b49da

File tree

11 files changed

+226
-183
lines changed

11 files changed

+226
-183
lines changed

docs/authentication.md

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ If you want to send notification emails using your Gmail account, and you have e
1717
```{versionadded} 1.21.0
1818
```
1919

20-
There are two ways to provide MFA code to `icloudpd`:
20+
There are two ways to provide an MFA code to `icloudpd`:
2121
- Using console
2222
- Using web interface
2323

@@ -28,7 +28,7 @@ Other options: *webui*
2828

2929
## Access from Mainland China
3030

31-
Access to iCloud.com is blocked from mainland China. `icloudpd` can be used with [`--domain cn`](domain-parameter) parameter to support downloading iCloud Photos from mainland China, however, people reported mixed results with that parameter.
31+
Access to iCloud.com is blocked from mainland China. `icloudpd` can be used with the [`--domain cn`](domain-parameter) parameter to support downloading iCloud Photos from mainland China; however, people have reported mixed results with that parameter.
3232

3333
## FIDO
3434

@@ -40,7 +40,7 @@ Advanced Data Protection (ADP) for iCloud accounts is not supported because `icl
4040

4141
## Occasional Errors
4242

43-
Some authentication errors may be resolved by clearing `.pyicloud` subfolder in the user's home directory. [Example](https://github.com/icloud-photos-downloader/icloud_photos_downloader/issues/772#issuecomment-1950963522)
43+
Some authentication errors may be resolved by clearing the `.pyicloud` subfolder in the user's home directory. [Example](https://github.com/icloud-photos-downloader/icloud_photos_downloader/issues/772#issuecomment-1950963522)
4444

4545
(password-providers)=
4646
## Password Providers
@@ -51,16 +51,16 @@ Some authentication errors may be resolved by clearing `.pyicloud` subfolder in
5151
WebUI support
5252
```
5353

54-
Passwords for iCloud access can be supplied by user in four ways:
54+
Passwords for iCloud access can be supplied by the user in four ways:
5555
- Using [`--password`](password-parameter) command line parameter
5656
- Using keyring
5757
- Using console
5858
- Using web interface
5959

60-
It is possible to specify which of these three ways `icloudpd` should use, by specifying them with [`--password-provider`](password-provider-parameter) parameter. More than one can be specified and the order
61-
of providers matches the order then will be checked for password. E.g. `--password-provider keyring --password-provider console` means that `icloudpd` will check password in keyring first and then, if no password found, ask for password in the console.
60+
It is possible to specify which of these four ways `icloudpd` should use, by specifying them with the [`--password-provider`](password-provider-parameter) parameter. More than one can be specified and the order
61+
of providers matches the order they will be checked for a password. E.g., `--password-provider keyring --password-provider console` means that `icloudpd` will check the password in the keyring first and then, if no password is found, ask for a password in the console.
6262

63-
Keyring password provider, if specified, saves valid password back into keyring.
63+
The keyring password provider, if specified, saves the valid password back into the keyring.
6464

6565
Console and Web UI are not compatible with each other. Console or WebUI providers, if specified, must be last in the list of providers because they cannot be skipped.
6666

@@ -90,7 +90,7 @@ Use `icloud`, not `icloudpd`
9090
(multiple-accounts-and-configs)=
9191
## Using Multiple Accounts and Config
9292

93-
`icloudpd` can process iCloud collections for multiple accounts or use multiple configs for one account. This is achived by specifying `--username` parameter multiples times: any options specified after `--username` will be applied to mentioned user only. Parameters specified before first `--username` work as defaults for all other user configs. Global app-wide settings can be specified anywhere.
93+
`icloudpd` can process iCloud collections for multiple accounts or use multiple configs for one account. This is achieved by specifying the `--username` parameter multiple times: any options specified after `--username` will be applied to the mentioned user only. Parameters specified before the first `--username` work as defaults for all other user configs. Global app-wide settings can be specified anywhere.
9494

9595
### Example: using two user accounts
9696

@@ -100,10 +100,10 @@ $ icloudpd --use-os-locale --cookie-directory ./cookies --username alice@apple.c
100100

101101
Explanation
102102

103-
- `--use-os-locale` is global parameter and can be used anywhere
104-
- `--cookie-directory` is a default for both users; it is okay to use same folder since session and coockies are stored in files based on user name, so they would not collide
105-
- `--directory ./alice` is specifying that all photos for Alice will be downloaded into ./alice folder
106-
- `--directory ./bob` is specifying that all photos for Alice will be downloaded into ./alice folder
103+
- `--use-os-locale` is a global parameter and can be used anywhere
104+
- `--cookie-directory` is a default for both users; it is okay to use the same folder since sessions and cookies are stored in files based on the user name, so they would not collide
105+
- `--directory ./alice` specifies that all photos for Alice will be downloaded into the ./alice folder
106+
- `--directory ./bob` specifies that all photos for Bob will be downloaded into the ./bob folder
107107

108108
### Example: using two configs for one account
109109

@@ -114,9 +114,9 @@ $ icloudpd --cookie-directory ./cookies --username alice@apple.com --directory .
114114
Explanation
115115

116116
- `--cookie-directory` is a default for both configs
117-
- `--directory ./photos --skip-videos` is specifying that all photos for Alice will be downloaded into ./photos folder
118-
- `--directory ./videos --skip-photos` is specifying that all videos for Alice will be downloaded into ./videos folder
119-
- `--use-os-locale` is global parameter and can be used anywhere
117+
- `--directory ./photos --skip-videos` specifies that all photos for Alice will be downloaded into the ./photos folder
118+
- `--directory ./videos --skip-photos` specifies that all videos for Alice will be downloaded into the ./videos folder
119+
- `--use-os-locale` is a global parameter and can be used anywhere
120120

121121
```{versionadded} 1.32.0
122122
```

docs/install.md

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ There are three ways to run `icloudpd`:
77
icloudpd --username your@email.address --directory photos --watch-with-interval 3600
88
```
99

10-
1. Use package manager to install, update, and, in some cases, run ([Docker](#docker), [PyPI](#pypi), [AUR](#aur), [npm](#npm))
11-
1. Build and run from the source
10+
1. Use a package manager to install, update, and, in some cases, run ([Docker](#docker), [PyPI](#pypi), [AUR](#aur), [npm](#npm))
11+
1. Build and run from source
1212

1313
(docker)=
1414
## Docker
@@ -17,9 +17,9 @@ There are three ways to run `icloudpd`:
1717
docker run -it --rm --name icloudpd -v $(pwd)/Photos:/data -e TZ=America/Los_Angeles icloudpd/icloudpd:latest icloudpd --directory /data --username my@email.address --watch-with-interval 3600
1818
```
1919

20-
Image asset date will be converted to specified TZ and then used for creating folders (see [`--folder-structure`](folder-structure-parameter) parameter)
20+
The image asset date will be converted to the specified TZ and then used for creating folders (see the [`--folder-structure`](folder-structure-parameter) parameter).
2121

22-
Synchronization logic can be adjusted with command-line parameters. Run the following to get full list:
22+
The synchronization logic can be adjusted with command-line parameters. Run the following to get the full list:
2323
``` sh
2424
docker run -it --rm icloudpd/icloudpd:latest icloudpd --help
2525
```
@@ -40,7 +40,7 @@ Getting Docker:
4040
4141
- On Linux, Docker engine and client can be installed using platform package managers, e.g. [Installing on Ubuntu](https://www.digitalocean.com/community/tutorials/how-to-install-and-use-docker-on-ubuntu-20-04)
4242
43-
- Appliance (e.g. NAS) will have their own way to install Docker engines and running containers - see manufacturer's instructions.
43+
- Appliances (e.g., NAS) will have their own way to install Docker engines and run containers - see the manufacturer's instructions.
4444
```
4545
4646
(pypi)=
@@ -65,7 +65,7 @@ on Windows:
6565
pip install icloudpd --user
6666
```
6767
68-
Plus add `C:\Users\<YourUserAccountHere>\AppData\Roaming\Python\Python<YourPythonVersionHere>\Scripts` to PATH. The exact path will be given at the end of `icloudpd` installation.
68+
Also add `C:\Users\<YourUserAccountHere>\AppData\Roaming\Python\Python<YourPythonVersionHere>\Scripts` to PATH. The exact path will be given at the end of the `icloudpd` installation.
6969
````
7070
7171
```{note}
@@ -88,7 +88,7 @@ cd icloudpd-bin
8888
makepkg -sirc
8989
```
9090
91-
With the use of the AUR helper e.g. [yay](https://github.com/Jguer/yay) the installation process would look like this:
91+
With the use of an AUR helper, e.g., [yay](https://github.com/Jguer/yay), the installation process would look like this:
9292
9393
``` sh
9494
yay -S icloudpd-bin
@@ -103,17 +103,17 @@ npx --yes icloudpd --directory /data --username my@email.address --watch-with-in
103103
104104
## macOS binary
105105
106-
`icloudpd` is available as Intel 64bit binary for macOS, but works on ARM macs too (M1, M2, M3).
106+
`icloudpd` is available as an Intel 64-bit binary for macOS, but works on ARM Macs too (M1, M2, M3).
107107
108-
Here are the steps to make it working:
109-
- download binary from GitHub [Releases](https://github.com/icloud-photos-downloader/icloud_photos_downloader/releases) into desired local folder
110-
- add executable flag by running `chmod +x icloudpd-1.32.0-macos-amd64`
111-
- start it from the terminal: `icloudpd-1.32.0-macos-amd64`
112-
- Apple will tell you that it cannot check for malicious software and refuse to run the app; click "Ok"
113-
- Open "System Settings"/"Privacy & Security" and find `icloudpd-1.32.0-macos-amd64` as blocked app; Click "Allow"
108+
Here are the steps to make it work:
109+
- Download the binary from GitHub [Releases](https://github.com/icloud-photos-downloader/icloud_photos_downloader/releases) into the desired local folder
110+
- Add the executable flag by running `chmod +x icloudpd-1.32.0-macos-amd64`
111+
- Start it from the terminal: `icloudpd-1.32.0-macos-amd64`
112+
- Apple will tell you that it cannot check for malicious software and refuse to run the app; click "OK"
113+
- Open "System Settings"/"Privacy & Security" and find `icloudpd-1.32.0-macos-amd64` as a blocked app; click "Allow"
114114
- Start `icloudpd-1.32.0-macos-amd64` from the terminal again
115115
- Apple will show another warning; click "Open"
116-
- After that you can run `icloudpd-1.32.0-macos-amd64 --help` or any other supported command/option
116+
- After that, you can run `icloudpd-1.32.0-macos-amd64 --help` or any other supported command/option
117117
118118
## Error on the First Run
119119

docs/mode.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,16 @@ Added `--delete-after-download` parameter
77
`icloudpd` works in one of three modes of operation:
88

99
Copy
10-
: Download assets from iCloud that are are not in the local storage
10+
: Download assets from iCloud that are not in the local storage
1111

1212
This is the default mode
1313

1414
Sync
15-
: Download assets from iCloud that are are not in the local storage (same as Copy). In addition, delete local files that were removed in iCloud (moved into "Recently Deleted" album)
15+
: Download assets from iCloud that are not in the local storage (same as Copy). In addition, delete local files that were removed in iCloud (moved into the "Recently Deleted" album)
1616

1717
This mode is selected with [`--auto-delete`](auto-delete-parameter) parameter
1818

1919
Move
20-
: Download assets from iCloud that are are not in the local storage (same as Copy). Then delete assets in iCloud that are in local storage, optionally leaving recent ones in iCloud
20+
: Download assets from iCloud that are not in the local storage (same as Copy). Then delete assets in iCloud that are in local storage, optionally leaving recent ones in iCloud
2121

2222
This mode is selected with [`--keep-icloud-recent-days`](keep-icloud-recent-days-parameter) parameter

docs/naming.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,20 +41,20 @@ LC_ALL=ru_RU.UTF.8 icloudpd --use-os-locale --version
4141
`--file-match-policy` parameter added and `name-id7` policy implemented
4242
```
4343

44-
In large iCloud collections it is possible to have name collisions. To avoid collisions if files need to be downloaded into the same folder, use [`--file-match-policy`](file-match-policy-parameter) parameter:
45-
- add unique invariant asset identification suffix to the name (e.g. **"IMG_1234_QAZXSW.JPG"**) with `--file-match-policy name-id7`
46-
- de-duplicate by adding file size as a suffix (e.g. **"IMG_1234-67890.JPG"** for second asset); `--file-match-policy name-size-dedup-with-suffix` - it is default
44+
In large iCloud collections, it is possible to have name collisions. To avoid collisions if files need to be downloaded into the same folder, use the [`--file-match-policy`](file-match-policy-parameter) parameter:
45+
- add a unique invariant asset identification suffix to the name (e.g., **"IMG_1234_QAZXSW.JPG"**) with `--file-match-policy name-id7`
46+
- de-duplicate by adding file size as a suffix (e.g., **"IMG_1234-67890.JPG"** for the second asset); `--file-match-policy name-size-dedup-with-suffix` - this is the default
4747

4848
## Live Photos
4949

5050
```{versionchanged} 1.18.0
5151
`--live-photo-mov-filename-policy` parameter added and `original` policy implemented
5252
```
5353

54-
Live Photo assets have two components: still image and short video. `icloudpd` can download both and allows customizing file name of the video portion with [`--live-photo-mov-filename-policy`](live-photo-mov-filename-policy-parameter) parameter:
54+
Live Photo assets have two components: a still image and a short video. `icloudpd` can download both and allows customizing the file name of the video portion with the [`--live-photo-mov-filename-policy`](live-photo-mov-filename-policy-parameter) parameter:
5555

56-
- Use video file name the same as still image with `original` policy; use `--file-match-policy name-id7` to avoid clashes of video file with other videos.
57-
- Use suffix from the still image with `suffix` policy: **"IMG_1234_HEVC.MOV"** for **"IMG_1234.HEIC"** still. This is default and works for HEIC still images only
56+
- Use the same video file name as the still image with the `original` policy; use `--file-match-policy name-id7` to avoid clashes of the video file with other videos.
57+
- Use a suffix from the still image with the `suffix` policy: **"IMG_1234_HEVC.MOV"** for **"IMG_1234.HEIC"** still image. This is the default and works for HEIC still images only
5858

5959
## Unicode
6060

docs/nas.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ The following are example setups for NAS.
44

55
## TrueNAS
66

7-
Use [`Install Custom App` button](https://www.truenas.com/docs/scale/23.10/scaletutorials/apps/usingcustomapp/) to set up `icloudpd`:
7+
Use the [`Install Custom App` button](https://www.truenas.com/docs/scale/23.10/scaletutorials/apps/usingcustomapp/) to set up `icloudpd`:
88
| Field | Value | Note |
99
|-------|-------|------|
1010
Application Name | `icloudpd` |
@@ -22,15 +22,15 @@ Portal Configuration/Protocol to Portal | `HTTP Protocol` |
2222
Portal Configuration/Use Node IP for Portal IP/Domain | checked |
2323
Portal Configuration/Port | `9090` | Same as "Port Forwarding/Host Port" above
2424

25-
Once the app has started, connect to the [WebUI](webui) to enter password and MFA code one of two ways:
26-
- Using browser from your PC to 9090 port of your NAS
27-
- Clicking on `icloudpd` button in Detail/Application Info section of TrueNAS portal
25+
Once the app has started, connect to the [WebUI](webui) to enter the password and MFA code in one of two ways:
26+
- Using a browser from your PC to port 9090 of your NAS
27+
- Clicking on the `icloudpd` button in the Detail/Application Info section of the TrueNAS portal
2828

2929
## Running on Synology NAS
3030

31-
The error `Failed to execv() /tmp/staticx-kJmNbp` has a workaround by (from an SSH terminal in my case) running `sudo mount /tmp -o remount,exec`. [#788](https://github.com/icloud-photos-downloader/icloud_photos_downloader/issues/788)
31+
The error `Failed to execv() /tmp/staticx-kJmNbp` has a workaround by running `sudo mount /tmp -o remount,exec` (from an SSH terminal). [#788](https://github.com/icloud-photos-downloader/icloud_photos_downloader/issues/788)
3232

33-
CPU/Arch [used by Synology](https://kb.synology.com/en-me/DSM/tutorial/What_kind_of_CPU_does_my_NAS_have) other than amd64 (after x12):
33+
CPU/Arch [used by Synology](https://kb.synology.com/en-me/DSM/tutorial/What_kind_of_CPU_does_my_NAS_have) other than amd64 (from x12 onwards):
3434
| Models | CPU | Arch |
3535
|-------|-------|------|
3636
DS124, DS423, DS223j, DS223 | Realtek RTD1619B | arm64 |
@@ -53,6 +53,6 @@ DS414j | Mindspeed Comcerto C200 | arm32v7
5353
DS413, DS213+ | Freescale P1022 | power (Unsupported) |
5454
DS413j, DS213, DS213air | Marvell Kirkwood 88F6282 | arm32v5 (Unsupported) |
5555

56-
Non x86 64bit models from x12 and before are not supported
56+
Non-x86 64-bit models from x12 and earlier are not supported.
5757

58-
[Additional info on Marvel](https://www.kernel.org/doc/html/v6.1/arm/marvell.html)
58+
[Additional info on Marvell](https://www.kernel.org/doc/html/v6.1/arm/marvell.html)

docs/raw.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,15 @@
33
## Apple ProRAW/ProRes
44

55
Apple supports shooting stills and videos in [DNG](https://en.wikipedia.org/wiki/Digital_Negative) format and
6-
they can be downloaded by `icloudpd` as any other supported format.
6+
they can be downloaded by `icloudpd` like any other supported format.
77

88
## Imported RAW images
99

1010
```{versionadded} 1.19.0
1111
```
1212

13-
RAW images from third party cameras can be imported into Apple Photos or uploaded to iCloud.com.
14-
These type of assets can also be downloaded by `icloudpd`. The following formats are recognized:
13+
RAW images from third-party cameras can be imported into Apple Photos or uploaded to iCloud.com.
14+
These types of assets can also be downloaded by `icloudpd`. The following formats are recognized:
1515

1616
- Adobe DNG - same as Apple ProRAW
1717
- Canon CR2, CR3, and CRW
@@ -29,13 +29,13 @@ These type of assets can also be downloaded by `icloudpd`. The following formats
2929

3030
iCloud supports images with two representations. `icloudpd` can download one or both representations.
3131

32-
One representation will be `original` [size](size) and another `alternative`.
32+
One representation will be the `original` [size](size) and the other `alternative`.
3333

34-
As of June 2024, icloud.com always shows assets with two representations as RAW+JPEG. Photo app on Mac
34+
As of June 2024, icloud.com always shows assets with two representations as RAW+JPEG. The Photos app on Mac
3535
allows choosing which representation to treat as original, but it is not clear what that setting changes.
3636

37-
`icloudpd` disambiguates the behavior with [`--align-raw`](align-raw-parameter) parameter:
37+
`icloudpd` disambiguates the behavior with the [`--align-raw`](align-raw-parameter) parameter:
3838

39-
- *original* always treat RAW as original [size](size)
40-
- *alternative* always treat RAW as alternative [size](size)
41-
- *as-is* treat RAW as it is in iCloud data
39+
- *original* always treats RAW as the original [size](size)
40+
- *alternative* always treats RAW as the alternative [size](size)
41+
- *as-is* treats RAW as it is in iCloud data

0 commit comments

Comments
 (0)