Fix Object Initializers Referencing Other Properties (#1080)

Co-authored-by: GrahamTheCoder <2490482+GrahamTheCoder@users.noreply.github.com>

Author: google-labs-jules[bot]

CodeConverter/CSharp/NameExpressionNodeVisitor.cs

@@ -87,8 +87,8 @@ public async Task<CSharpSyntaxNode> ConvertMemberAccessExpressionAsync(VBasic.Sy
             if (IsSubPartOfConditionalAccess(node)) {
                 return isDefaultProperty ? SyntaxFactory.ElementBindingExpression()
                     : await AdjustForImplicitInvocationAsync(node, SyntaxFactory.MemberBindingExpression(simpleNameSyntax));
-            } else if (node.IsParentKind(VBasic.SyntaxKind.NamedFieldInitializer)) {
-                return ValidSyntaxFactory.IdentifierName(_tempNameForAnonymousScope[node.Name.Identifier.Text].Peek().TempName);
+            } else if (node.IsParentKind(VBasic.SyntaxKind.NamedFieldInitializer) && _tempNameForAnonymousScope.TryGetValue(node.Name.Identifier.Text, out var stack) && stack.Any()) {
+                return ValidSyntaxFactory.IdentifierName(stack.Peek().TempName);
             }
             left = _withBlockLhs.Peek();
         }

Tests/VB/ExpressionTests.cs

@@ -587,6 +587,57 @@ End Sub
 End Class");
     }
 
+    [Fact]
+    public async Task ObjectInitializerExpressionReferencingOtherPropertyAsync()
+    {
+        await TestConversionVisualBasicToCSharpAsync(@"Imports System.Drawing
+
+Public Class VisualBasicClass
+    Public Sub M()
+        Dim Shape = New Point() With {
+            .X = 1,
+            .Y = .X
+        }
+    End Sub
+End Class", @"using System.Drawing;
+
+public partial class VisualBasicClass
+{
+    public void M()
+    {
+        Point @init = new Point();
+        var Shape = (@init.X = 1, @init.Y = @init.X, @init).@init;
+    }
+}");
+    }
+
+    [Fact]
+    public async Task AdvancedObjectInitializerExpressionReferencingOtherPropertyAsync()
+    {
+        await TestConversionVisualBasicToCSharpAsync(@"Imports System.Drawing
+
+Public Class VisualBasicClass
+    Public Sub M()
+        Dim Shape = New Rectangle() With {
+            .X = 1,
+            .Y = .X + 10,
+            .Width = .X + .Y,
+            .Height = System.Math.Max(.Width, .Y)
+        }
+    End Sub
+End Class", @"using System;
+using System.Drawing;
+
+public partial class VisualBasicClass
+{
+    public void M()
+    {
+        Rectangle @init = new Rectangle();
+        var Shape = (@init.X = 1, @init.Y = @init.X + 10, @init.Width = @init.X + @init.Y, @init.Height = Math.Max(@init.Width, @init.Y), @init).@init;
+    }
+}");
+    }
+
     [Fact]
     public async Task ObjectInitializerExpression3Async()
     {