Add validation for terms to be lowercase and sorted

Author: FloEdelmann

lib/build.js

@@ -260,6 +260,7 @@ function generateFields(dataDir, tstrings, searchableFieldIDs) {
       delete field.label;
     }
 
+    validateTerms(field.terms, `field "${id}"`);
     tstrings.fields[id].terms = Array.from(new Set(
       (field.terms || [])
         .map(t => t.toLowerCase().trim())
@@ -337,6 +338,7 @@ function generatePresets(dataDir, tstrings, searchableFieldIDs, listReusedIcons)
     ));
     preset.aliases.forEach(a => names.add(a.toLowerCase()));
 
+    validateTerms(preset.terms, `preset "${id}"`);
     preset.terms = Array.from(new Set(
       (preset.terms || [])
         .map(t => t.toLowerCase().trim())
@@ -854,7 +856,17 @@ function validatePresetFields(presets, fields) {
       process.stdout.write('Field "' + fields[fieldID].label + '" (' + fieldID + ') isn\'t used by any presets.\n');
     }
   }
+}
+
+function validateTerms(terms, where) {
+  if (!terms) return;
+  
+  const expectedTerms = terms.map(term => term.toLowerCase().trim()).sort()
+  if (terms.every((term, index) => expectedTerms[index] === term)) return
 
+  process.stderr.write(`Expected terms in ${where} to be lowercase and sorted alphabetically.`);
+  process.stdout.write('\n');
+  process.exit(1);
 }
 
 function validateDefaults(defaults, categories, presets) {