docs: update instructions and prompts for clarity and route usage

Generated-by: aiautocommit

Author: iloveitaly

.cursor/rules/react-router-client-loader.mdc

@@ -1,7 +1,6 @@
 ---
-description: Move logic into a client loader
+description: 
 ---
 ## React Router Client Loader
 
-
 Do this in a `clientLoader` and use `loaderData` to render the component. DO NOT create mock data, new interfaces, or mock data loader functions. Instead, assume `loaderData` has all of the data you need to render the component.

.cursor/rules/secrets.mdc

@@ -1,9 +1,8 @@
 ---
-description: Add or mutate system secrets
+description: 
 ---
 ## Secrets
 
-
 Here's how environment variables are managed in this application:
 
 - `.envrc` entry point to load the correct env stack. Should not contain secrets and should be simple some shell logic and direnv stdlib calls.

.cursor/rules/typescript-docstring.mdc

@@ -1,9 +1,6 @@
 ---
-description:
-globs:
-alwaysApply: false
+description: 
 ---
 ## TypeScript DocString
 
-
 Add a file-level docstring with a simple description of what this file does.

.github/instructions/react-router.instructions.md

@@ -5,8 +5,6 @@ applyTo: "web/app/routes/**/*.tsx"
 
 - The primary export in a routes file should specify `loaderData` like `export default function RouteNamePage({ loaderData }: Route.ComponentProps)`. `loaderData` is the return value from `clientLoader`.
 - When using an import from `~/configuration/client` (1) use `body:` for request params and (2) always `const { data, error } = await theCall()` (3) add `invariant(data, "error loading $xyz")`
-- Use `href("/products/:id", { id: "abc123" })` to generate a url path for a route managed by the application.
-  - Look at [routes.ts](mdc:web/app/routes.ts) to determine what routes and path parameters exist.
 - Use `export async function clientLoader(loaderArgs: Route.ClientLoaderArgs)` to define a clientLoader on a route.
   - Use `loaderArgs.params.$THE_KEY` to use a query string parameter.
 - Do not define `Route.*` types, these are autogenerated and can be imported from `import type { Route } from "./+types/routeFileName"`

.github/instructions/react.instructions.md

@@ -17,9 +17,11 @@ applyTo: "**/*.tsx"
 - Only use a separate interface for component props if there are more than 4 props.
   - Put the interface definition right above the related function
 - Internally, store all currency values as integers and convert them to floats when rendering visually
-- Never edit the `components/ui/*.tsx` files
+- Never edit (or add) `components/ui/*.tsx` files
 - When building forms use React Hook Form.
 - Include a two line breaks between any `useHook()` calls and any `useState()` definitions for a component.
+- Use `href("/products/:id", { id: "abc123" })` to generate a url path for a route managed by the application.
+  - Look at @routes.ts to determine what routes and path parameters exist.
 
 ### React Hook Form
 

.github/prompts/react-router-client-loader.prompt.md

@@ -1,8 +1,7 @@
 ---
 mode: 'agent'
-description: 'Move logic into a client loader'
+description: ''
 ---
 ## React Router Client Loader
 
-
 Do this in a `clientLoader` and use `loaderData` to render the component. DO NOT create mock data, new interfaces, or mock data loader functions. Instead, assume `loaderData` has all of the data you need to render the component.

.github/prompts/secrets.prompt.md

@@ -1,10 +1,9 @@
 ---
 mode: 'agent'
-description: 'Add or mutate system secrets'
+description: ''
 ---
 ## Secrets
 
-
 Here's how environment variables are managed in this application:
 
 - `.envrc` entry point to load the correct env stack. Should not contain secrets and should be simple some shell logic and direnv stdlib calls.

.github/prompts/typescript-docstring.prompt.md

@@ -1,8 +1,7 @@
 ---
 mode: 'agent'
-description: 'Add a docstring to a TypeScript file'
+description: ''
 ---
 ## TypeScript DocString
 
-
 Add a file-level docstring with a simple description of what this file does.