Abailly iohk/add more logging#4
Merged
9 commits merged intoMay 27, 2021
Merged
Conversation
There is confusion with another Logging module in local-cluster which should probably be renamed too, or even deleted
This needed simplification of `Wait` effect which is not used anyway, in order to define a `Show` instance
Event handling (and subsequent Head state update) is decoupled from side-effects processing. And error reporting is more uniform.
ghost
requested review from
KtorZ
approved these changes
May 27, 2021
KtorZ
left a comment
KtorZ
left a comment
Collaborator
There was a problem hiding this comment.
Happy to see traces in the tests 🎉
ch1bo
approved these changes
May 27, 2021
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is essentially the continuation of yesterday's work on logging, with more traces added for events and effects handling. The last commit contains a proposed refactoring to decouple events handling from effects processing which seems to me clearer.