Skip to content

Commit 0d82d52

Browse files
committed
Fix grouped entities view
1 parent 4561040 commit 0d82d52

6 files changed

Lines changed: 15 additions & 15 deletions

File tree

client/src/api/evaluation.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ export function getMetrics(corpus: UUID, hypothesis: string, reference: string):
6464
* @param reference Tagger job name as reference layer.
6565
*/
6666
export function getDownloadEvaluation(corpus: UUID, hypothesis: string, reference: string): Promise<BlobResponse> {
67-
return getBlob(downloadPath(corpus, hypothesis), { params: { reference } })
67+
return getBlob(downloadPath(corpus), { params: { reference, hypothesis } })
6868
}
6969

7070
/**

client/src/components/tables/CorpusTable.vue

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ const { loading, corpusId, corpus } = storeToRefs(stores.useCorpora())
4141
const selectedCorpus = computed<CorpusMetadata>({
4242
get: () => corpus.value,
4343
set: (value: CorpusMetadata) => {
44-
console.log("Selected corpus", value)
4544
corpusId.value = value.uuid
4645
},
4746
})

client/src/components/tables/MetricsTable.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
<p>Generating metrics for large corpora may take a while...</p>
1212
</template>
1313

14-
<template #header>
15-
<slot name="prepend"></slot>
14+
<template #header v-else>
15+
<slot name="header"></slot>
1616
</template>
1717

1818
<template

client/src/components/tables/SingleTermComparisonTable.vue

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,7 @@
99
</template>
1010

1111
<script setup lang="ts">
12-
// Libraries & stores
13-
1412
import stores from "@/stores"
15-
// Types & API
1613
import type { Term } from "@/types/evaluation"
1714
import type { Column } from "@/types/ui/table"
1815
@@ -71,7 +68,7 @@ function cleanAnnotation(term) {
7168
background-color: rgba(255, 0, 0, 0.1);
7269
}
7370
74-
.termCompTable :deep(td) {
75-
padding: 0 !important;
76-
}
71+
//.termCompTable :deep(td) {
72+
// padding: 0 !important;
73+
//}
7774
</style>

client/src/views/annotate/subviews/evaluate/subviews/EntitiesView.vue

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@ const entityOptions = computed(() => {
8888
// in which indices of entittyLegend does this label occur?
8989
const occurence = []
9090
for (const [i, job] of Object.keys(entities.value.jobs).entries()) {
91-
console.log("job", job, "i", i)
9291
if (entities.value.jobs[job].summary[label] !== undefined) {
9392
occurence.push(i + 1) // +1 because we want to start from 1, not 0
9493
}

client/src/views/annotate/subviews/evaluate/subviews/GroupedMetricsView.vue

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,11 @@
1616
</p>
1717
</template>
1818
<template #header v-if="metrics.metrics != null">
19+
<GSelect :options="groupingOptions" v-model="selectedGrouping" />
1920
<p>
2021
<b> Only the 100 most frequent groups are shown. </b>
2122
</p>
22-
<MetricsFilter ref="metricsFilter" :annotations="metrics.metrics" />
23+
<!-- <MetricsFilter ref="metricsFilter" :annotations="metrics.metrics" /> -->
2324
</template>
2425
</MetricsTable>
2526
</div>
@@ -42,6 +43,10 @@ const jobSelection = stores.useJobSelection()
4243
4344
// Fields
4445
const downloading = ref<boolean>()
46+
const selectedGrouping = ref<string>("lemmaByLemma")
47+
const groupingOptions = computed(() =>
48+
Object.keys(metrics.value?.metrics || {}).map((key) => ({ value: key, text: key })),
49+
)
4550
4651
const columns = computed(() => metricsPerPosColumns)
4752
const metricsFilter = useTemplateRef<InstanceType<typeof MetricsFilter>>("metricsFilter")
@@ -50,13 +55,13 @@ const metricName = computed(() => {
5055
})
5156
5257
const posMetrics = computed(() => {
53-
if (metrics.value?.metrics?.[metricName.value] == null) return []
58+
if (metrics.value?.metrics?.[selectedGrouping.value] == null) return []
5459
// Copy over the metrics (depending on selectedMetric.value) from:
5560
// { ADJ: { ADJ: { pos : { f1, recall, ... }, lemma : { f1, recall, ... } } } } }
5661
// to:
5762
// { ADJ: { ADJ: { f1, recall, ..., } } }
58-
const ret = metrics.value.metrics[metricName.value].grouped.map((i) => ({
59-
column: metricName.value.split("By")[1].toLowerCase(),
63+
const ret = metrics.value.metrics[selectedGrouping.value].grouped.map((i) => ({
64+
column: selectedGrouping.value.split("By")[1].toLowerCase(),
6065
name: i.name,
6166
count: i.classes.classCount,
6267
truePositive: i.classes.truePositive,

0 commit comments

Comments
 (0)