Skip to content

Commit e34bb45

Browse files
committed
Fix test: layer.tostring() instead of plaintext
1 parent 314e4b0 commit e34bb45

7 files changed

Lines changed: 16 additions & 13 deletions

File tree

server/src/test/kotlin/org/ivdnt/galahad/data/documents/DocumentMetadataTest.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,8 @@ class DocumentMetadataTest {
3636
@Test
3737
fun `Properties for an annotated file`() {
3838
val path = "all-formats/input/input.tei.xml"
39-
val file = TestUtil.get(path)
4039
val doc = TestUtil.getDoc(path)
41-
val plaintext = doc.plaintext
40+
val plaintext = TestUtil.getLayer(doc).toString()
4241
val meta = doc.metadata
4342
assertEquals("input.tei.xml", meta.name)
4443
assertEquals(DocumentFormat.TeiP5, meta.format)

server/src/test/kotlin/org/ivdnt/galahad/formats/tei/TEIExportTest.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,13 +73,13 @@ internal class TEIExportTest {
7373
fun punctuationExportTest() {
7474

7575
val teiFile = TeiFile(TestUtil.get("tei/oneparagraph/mocktei.xml"))
76-
DocTest.builder(corpus).expecting("Dit is wat oefentekst.").got(teiFile.plaintext)
76+
DocTest.builder(corpus).expecting("Dit is wat oefentekst.").got(teiFile.layer.toString())
7777
.ignoreTrailingWhiteSpaces().result()
7878

7979
val tagset = Tagset.readOrThrow("TDN-Core")
8080

8181
val layer = LayerBuilder().loadLayerFromTSV(
82-
"tei/export/mock-TDN-with-punctuation.tsv", teiFile.plaintext
82+
"tei/export/mock-TDN-with-punctuation.tsv", teiFile.layer.toString()
8383
).build()
8484

8585
DocTest.builder(corpus).expectingFile("tei/export/mock-TDN-with-punctuation-result.xml")
@@ -92,7 +92,7 @@ internal class TEIExportTest {
9292
fun mergePuncutationTest() {
9393

9494
val tagset = Tagset.readOrThrow("TDN-Core")
95-
val plaintext = TeiFile(TestUtil.get("tei/dummies/punctutation-mixed-tags.xml")).plaintext
95+
val plaintext = TeiFile(TestUtil.get("tei/dummies/punctutation-mixed-tags.xml")).layer.toString()
9696
val layer = LayerBuilder().loadLayerFromTSV("tei/dummies/punctuation-mixed-tags-sample-layer.tsv", plaintext)
9797
.build()
9898

server/src/test/kotlin/org/ivdnt/galahad/formats/tei/TeiReaderTest.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,19 +11,19 @@ internal class TeiReaderTest {
1111
@Test
1212
fun `Multiple text elements`() {
1313
val teiFile = TeiFile(TestUtil.get("formats/tei/dummies/multipletextelements.xml"))
14-
assertEquals("text1\ntext2 text3", teiFile.plaintext.trim())
14+
assertEquals("text1\ntext2 text3", teiFile.layer.toString())
1515
}
1616

1717
@Test
1818
fun `Simple word tags in one paragraph`() {
1919
val teiFile = TeiFile(TestUtil.get("formats/tei/dummies/withwtags.xml"))
20-
assertEquals("word1 word2", teiFile.plaintext.trim())
20+
assertEquals("word1 word2", teiFile.layer.toString())
2121
}
2222

2323
@Test
2424
fun `Simple word tags in two paragraph`() {
2525
val teiFile = TeiFile(TestUtil.get("formats/tei/dummies/wandp.xml"))
26-
assertEquals("word1 word2\n\nword3 word4", teiFile.plaintext.trim())
26+
assertEquals("word1 word2\n\nword3 word4", teiFile.layer.toString())
2727
}
2828

2929
@Test
@@ -42,7 +42,7 @@ internal class TeiReaderTest {
4242
@Test
4343
fun `Import TEI with w-tags without spaces in between`() {
4444
val file = TeiFile(TestUtil.get("formats/tei/nospaces/input.tei.xml"))
45-
assertEquals("a a a", file.plaintext.trim())
45+
assertEquals("a a a", file.layer.toString())
4646

4747
}
4848
}

server/src/test/kotlin/org/ivdnt/galahad/formats/tsv/TSVBodyTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ internal class TSVBodyTest {
2727
val tsvFile = TsvFile(File("src/test/resources/tsv/body/extra-columns.tsv"))
2828
assertTSVFile(tsvFile)
2929
val expected = "scholen loop " // Note the space.
30-
assertEquals(expected, tsvFile.plaintext)
30+
assertEquals(expected, tsvFile.layer.toString())
3131
}
3232

3333
@Test

server/src/test/kotlin/org/ivdnt/galahad/formats/tsv/TSVPlaintextTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,6 @@ internal class TSVPlaintextTest {
1212
assertEquals(1812, tsvFile.layer.terms.count())
1313
// Assert plaintext.
1414
val plainText = File("src/test/resources/tsv/plaintext/peerle.txt").readText()
15-
assertEquals(plainText, tsvFile.plaintext)
15+
assertEquals(plainText, tsvFile.layer.toString())
1616
}
1717
}

server/src/test/kotlin/org/ivdnt/galahad/jobs/JobTest.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ class JobTest {
2626
// verify
2727
assertEquals(TestConfig.TAGGER_NAME, job.name)
2828
assertFalse(job.isActive)
29-
assertEquals(0, job.assay.readOrThrow<Map<String, FlatMetricType>>().size)
3029
assertEquals(0, job.progress.total)
3130
// verify from state cache
3231
assertEquals(LayerPreview.EMPTY, job.metadata.preview)

server/src/test/kotlin/org/ivdnt/galahad/util/TestUtil.kt

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ import com.fasterxml.jackson.databind.ObjectMapper
77
import com.fasterxml.jackson.databind.SerializationFeature
88
import com.fasterxml.jackson.databind.cfg.DatatypeFeature
99
import com.fasterxml.jackson.databind.json.JsonMapper
10+
import org.ivdnt.galahad.annotations.Layer
11+
import org.ivdnt.galahad.annotations.SOURCE_LAYER_NAME
1012
import org.ivdnt.galahad.app.User
1113
import org.ivdnt.galahad.corpora.Corpora
1214
import org.ivdnt.galahad.corpora.Corpus
@@ -30,6 +32,9 @@ object TestUtil {
3032
return corpus.documents.readOrNull(file.name) ?: corpus.documents.createOrThrow(file)
3133
}
3234

35+
fun getLayer(doc: Document, job: String = SOURCE_LAYER_NAME): Layer =
36+
corpus.jobs.readOrThrow(job).getLayer(doc.name)
37+
3338
val mapper: ObjectMapper = JsonMapper.builder()
3439
.configure(MapperFeature.SORT_PROPERTIES_ALPHABETICALLY, true)
3540
.configure(SerializationFeature.ORDER_MAP_ENTRIES_BY_KEYS, true)
@@ -61,7 +66,7 @@ object TestUtil {
6166
fun assertPlainText(folder: String, file: InternalFile) {
6267
// Plain text
6368
val plaintext = get("$folder/plaintext.txt").readText()
64-
assertEquals(plaintext, file.plaintext)
69+
assertEquals(plaintext, file.layer.toString())
6570
}
6671

6772
fun assertPlaintextAndSourcelayer(folder: String, file: InternalFile) {

0 commit comments

Comments
 (0)