Skip to content

Consistent qualified imports #5835

@lehins

Description

@lehins

Text

It is more consistent to import Text qualified as T, instead of Text, so we should make it consistent and switch all Data.Text* occurnaces to as T:

[nix-shell:~/iohk/cardano-ledger]$ git grep "import qualified Data.Text as Text$" | wc -l
14
[nix-shell:~/iohk/cardano-ledger]$ git grep "import qualified Data.Text as T$" | wc -l
49

ByteString

Other qualified imports that needs fixing:

import qualified Data.ByteString as BS
import qualified Data.ByteString.Short as SBS
import qualified Data.ByteString.Lazy as BSL

Here is some proof for anyone that wants to object:

[nix-shell:~/iohk/cardano-ledger]$ git grep "import qualified Data.ByteString.Lazy as LBS" | wc -l
19
[nix-shell:~/iohk/cardano-ledger]$ git grep "import qualified Data.ByteString.Lazy as BSL" | wc -l
57

Others:

  • Data.List.NonEmpty as NE, not as NonEmpty, etc.
import qualified Data.List.NonEmpty as NE
  • import qualified Data.Foldable as F, not as Foldable, etc.
import qualified Data.Foldable as F
  • Data.Aeson*, eg.:
import qualified Data.Aeson as Aeson
import qualified Data.Aeson.Key as Aeson
import qualified Data.Aeson.Encoding as Aeson
  • BaseX encoding
import qualified Data.ByteString.Base16 as BS16
import qualified Data.ByteString.Base64 as BS64

More bullet points are likely to be added later

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    Status
    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions