Text
It is more consistent to import Text qualified as T, instead of Text, so we should make it consistent and switch all Data.Text* occurnaces to as T:
[nix-shell:~/iohk/cardano-ledger]$ git grep "import qualified Data.Text as Text$" | wc -l
14
[nix-shell:~/iohk/cardano-ledger]$ git grep "import qualified Data.Text as T$" | wc -l
49
ByteString
Other qualified imports that needs fixing:
import qualified Data.ByteString as BS
import qualified Data.ByteString.Short as SBS
import qualified Data.ByteString.Lazy as BSL
Here is some proof for anyone that wants to object:
[nix-shell:~/iohk/cardano-ledger]$ git grep "import qualified Data.ByteString.Lazy as LBS" | wc -l
19
[nix-shell:~/iohk/cardano-ledger]$ git grep "import qualified Data.ByteString.Lazy as BSL" | wc -l
57
Others:
Data.List.NonEmpty as NE, not as NonEmpty, etc.
import qualified Data.List.NonEmpty as NE
import qualified Data.Foldable as F, not as Foldable, etc.
import qualified Data.Foldable as F
import qualified Data.Aeson as Aeson
import qualified Data.Aeson.Key as Aeson
import qualified Data.Aeson.Encoding as Aeson
import qualified Data.ByteString.Base16 as BS16
import qualified Data.ByteString.Base64 as BS64
More bullet points are likely to be added later
Text
It is more consistent to import
Textqualified asT, instead ofText, so we should make it consistent and switch allData.Text*occurnaces toas T:ByteString
Other qualified imports that needs fixing:
Here is some proof for anyone that wants to object:
Others:
Data.List.NonEmpty as NE, notas NonEmpty, etc.import qualified Data.Foldable as F, notas Foldable, etc.Data.Aeson*, eg.:More bullet points are likely to be added later