Skip to content

Commit 86645ef

Browse files
authored
chore: drop unused ReceiverStreamBuilder spawn (delta-io#4201)
# Description clean up from DF52 upgrade # Related Issue(s) <!--- For example: - closes delta-io#106 ---> # Documentation <!--- Share links to useful documentation ---> Signed-off-by: Ethan Urbanski <ethan@urbanskitech.com>
1 parent 8626029 commit 86645ef

1 file changed

Lines changed: 2 additions & 13 deletions

File tree

crates/core/src/kernel/snapshot/stream.rs

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
//!
33
use arrow::{datatypes::SchemaRef, record_batch::RecordBatch};
44
use futures::stream::BoxStream;
5-
use futures::{Future, Stream, StreamExt};
5+
use futures::{Stream, StreamExt};
66
use std::pin::Pin;
77
use tokio::sync::mpsc::{Receiver, Sender};
88
use tokio::task::JoinSet;
@@ -57,7 +57,7 @@ pub type SendableRBStream = Pin<Box<dyn Stream<Item = DeltaResult<RecordBatch>>
5757
///
5858
/// Note that this is similar to [`ReceiverStream` from tokio-stream], with the differences being:
5959
///
60-
/// 1. Methods to bound and "detach" tasks (`spawn()` and `spawn_blocking()`).
60+
/// 1. Methods to bound and "detach" tasks (`spawn_blocking()`).
6161
///
6262
/// 2. Propagates panics, whereas the `tokio` version doesn't propagate panics to the receiver.
6363
///
@@ -87,17 +87,6 @@ impl<O: Send + 'static> ReceiverStreamBuilder<O> {
8787
self.tx.clone()
8888
}
8989

90-
/// Spawn task that will be aborted if this builder (or the stream
91-
/// built from it) are dropped
92-
#[allow(unused)]
93-
pub fn spawn<F>(&mut self, task: F)
94-
where
95-
F: Future<Output = DeltaResult<()>>,
96-
F: Send + 'static,
97-
{
98-
self.join_set.spawn(task);
99-
}
100-
10190
/// Spawn a blocking task that will be aborted if this builder (or the stream
10291
/// built from it) are dropped.
10392
///

0 commit comments

Comments
 (0)