Skip to content

Commit 7c1a048

Browse files
committed
chore(ci): add node 18 (#4069)
this commit increments the versions of node & npm `package.json#volta`. this change sets a new baseline for the versions of npm and node that will be used for the day-to-day development on the project. to coincide with this change, node 18 has been added to the github actions workflow. starting with node 18, we started to have issues where karma tests couldn't run (would fail to proxy the page being served). this happened both locally and in CI. updating the karma dependencies resolves the problem (although _why_ is unknown)
1 parent 7bccf68 commit 7c1a048

File tree

9 files changed

+33
-33
lines changed

9 files changed

+33
-33
lines changed

.github/dependabot.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ updates:
1313
rebase-strategy: 'disabled'
1414
ignore:
1515
- dependency-name: '@types/node'
16-
versions: ['17', '18']
16+
versions: ['>=19']
1717
- dependency-name: 'typescript'
1818
versions: ['>=4.10', '>=5.0']
1919
# disable Jest updates until the new testing architecture is in place

.github/workflows/test-analysis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
strategy:
1212
fail-fast: false
1313
matrix:
14-
node: ['14', '16']
14+
node: ['14', '16', '18']
1515
os: ['ubuntu-20.04', 'windows-latest']
1616
runs-on: ${{ matrix.os }}
1717
steps:

.github/workflows/test-component-starter.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
strategy:
1212
fail-fast: false
1313
matrix:
14-
node: ['14', '16']
14+
node: ['14', '16', '18']
1515
os: ['ubuntu-latest', 'windows-latest']
1616
runs-on: ${{ matrix.os }}
1717
steps:

.github/workflows/test-e2e.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
strategy:
1212
fail-fast: false
1313
matrix:
14-
node: ['14', '16']
14+
node: ['14', '16', '18']
1515
os: ['ubuntu-20.04', 'windows-latest']
1616
runs-on: ${{ matrix.os }}
1717
steps:

.github/workflows/test-unit.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
strategy:
1212
fail-fast: false
1313
matrix:
14-
node: ['14', '16']
14+
node: ['14', '16', '18']
1515
os: ['ubuntu-20.04', 'windows-latest']
1616
runs-on: ${{ matrix.os }}
1717
steps:

package-lock.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
"@types/inquirer": "^7.3.1",
7171
"@types/jest": "^27.0.3",
7272
"@types/listr": "^0.14.4",
73-
"@types/node": "^16.11.62",
73+
"@types/node": "^18.14.0",
7474
"@types/pixelmatch": "^5.2.4",
7575
"@types/pngjs": "^6.0.1",
7676
"@types/prompts": "^2.0.9",
@@ -147,7 +147,7 @@
147147
],
148148
"prettier": "@ionic/prettier-config",
149149
"volta": {
150-
"node": "16.13.0",
151-
"npm": "8.1.1"
150+
"node": "18.14.1",
151+
"npm": "9.3.1"
152152
}
153153
}

test/bundler/package-lock.json

Lines changed: 15 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/bundler/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@
1212
},
1313
"devDependencies": {
1414
"@types/karma": "^6.3.3",
15-
"@types/node": "^16.18.6",
16-
"karma": "^6.3.17",
17-
"karma-chrome-launcher": "^3.1.0",
15+
"@types/node": "^18.13.0",
16+
"karma": "^6.4.1",
17+
"karma-chrome-launcher": "^3.1.1",
1818
"karma-jasmine": "^5.0.0",
1919
"karma-typescript": "^5.5.3",
2020
"ts-node": "^10.7.0"

0 commit comments

Comments
 (0)