Skip to content
This repository was archived by the owner on Aug 11, 2021. It is now read-only.

Commit b7a565b

Browse files
committed
fix: out of scope traversal for 2 or more levels deep
1 parent 2e91d7c commit b7a565b

2 files changed

Lines changed: 5 additions & 6 deletions

File tree

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "ipld-dag-cbor",
33
"version": "0.6.0",
44
"description": "JavaScript implementation of the IPLD (InterpPlanetary Linked Data)",
5-
"main": "src/index.js",
5+
"main": "lib/index.js",
66
"jsnext:main": "src/index.js",
77
"scripts": {
88
"test": "aegir-test",
@@ -49,6 +49,7 @@
4949
"aegir": "8.1.2",
5050
"async": "^2.1.2",
5151
"chai": "^3.5.0",
52+
"ipfs-block": "^0.4.0",
5253
"pre-commit": "^1.1.3"
5354
},
5455
"contributors": [

src/resolver.js

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,13 +45,11 @@ exports.resolve = (block, path, callback) => {
4545
}
4646

4747
// out of scope
48-
49-
// TODO this was my first try at writting this out of scope traversal code,
50-
// it REALLY needs way more testing.
5148
let value
49+
let len = parts.length
5250

53-
for (let i = 0; i < parts.length; i++) {
54-
let partialPath = parts.shift()
51+
for (let i = 0; i < len; i++) {
52+
const partialPath = parts.shift()
5553

5654
if (Array.isArray(node) && !Buffer.isBuffer(node)) {
5755
value = node[Number(partialPath)]

0 commit comments

Comments
 (0)