feat: allow the output file to not include the hostname

Author: mvegter

README.md

@@ -33,7 +33,7 @@ Convert coverage from the format outputted by [puppeteer](https://developers.goo
         page.coverage.stopJSCoverage(),
         page.coverage.stopCSSCoverage(),
       ]);
-      pti.write([...jsCoverage, ...cssCoverage])
+      pti.write([...jsCoverage, ...cssCoverage], { includeHostname: true })
       await browser.close()
     })()
     ```

index.js

@@ -1,8 +1,8 @@
 const PuppeteerToIstanbul = require('./lib/puppeteer-to-istanbul')
 
 module.exports = {
-  write: (puppeteerFormat) => {
-    const pti = PuppeteerToIstanbul(puppeteerFormat)
+  write: (puppeteerFormat, options) => {
+    const pti = PuppeteerToIstanbul(puppeteerFormat, options)
     pti.writeIstanbulFormat()
   }
 }

lib/output-files.js

@@ -13,7 +13,8 @@ const storagePath = './.nyc_output/js'
 let iterator = {}
 
 class OutputFiles {
-  constructor (coverageInfo) {
+  constructor (coverageInfo, options = {}) {
+    this.includeHostname = options.hasOwnProperty('includeHostname') ? options.includeHostname : true
     // Clone coverageInfo to prevent mutating the passed in data
     this.coverageInfo = clone(coverageInfo)
     this._parseAndIsolate()
@@ -31,7 +32,7 @@ class OutputFiles {
 
     let postProtocolPath = urlPath.pathname.substring(1)
 
-    if (urlPath.hostname) {
+    if (urlPath.hostname && this.includeHostname) {
       let hostnameAndPort = urlPath.hostname
       if (urlPath.port) {
         hostnameAndPort = hostnameAndPort + '_' + urlPath.port
@@ -90,8 +91,8 @@ class OutputFiles {
   }
 }
 
-function genOutputFiles (coverageInfo) {
-  return new OutputFiles(coverageInfo)
+function genOutputFiles (coverageInfo, options) {
+  return new OutputFiles(coverageInfo, options)
 }
 
 genOutputFiles.resetIterator = function () {

lib/puppeteer-to-istanbul.js

@@ -7,9 +7,9 @@ const v8toIstanbul = require('v8-to-istanbul')
 let jsonPart = {}
 
 class PuppeteerToIstanbul {
-  constructor (coverageInfo) {
+  constructor (coverageInfo, options) {
     this.coverageInfo = coverageInfo
-    this.puppeteerToConverter = OutputFiles(coverageInfo).getTransformedCoverage()
+    this.puppeteerToConverter = OutputFiles(coverageInfo, options).getTransformedCoverage()
     this.puppeteerToV8Info = PuppeteerToV8(this.puppeteerToConverter).convertCoverage()
   }
 
@@ -61,8 +61,8 @@ function mergeCoverageData (obja, objb) {
   return obja
 }
 
-function genPuppeteerToIstanbul (coverageInfo) {
-  return new PuppeteerToIstanbul(coverageInfo)
+function genPuppeteerToIstanbul (coverageInfo, options) {
+  return new PuppeteerToIstanbul(coverageInfo, options)
 }
 
 genPuppeteerToIstanbul.resetJSONPart = function () {

test/output-files.js

@@ -79,6 +79,16 @@ describe('output-files', () => {
     coverageInfo[3].url.should.include('js/views/record.js')
   })
 
+  it('appropriately handles modules required via http/https, with hostName excluded', () => {
+    const fixture = require('./fixtures/http-es6-modules.json')
+    const coverageInfo = OutputFiles(fixture, { includeHostname: false }).getTransformedCoverage().map(info => ({...info, url: info.url.replace(/\\/g, '/')}))
+
+    coverageInfo[0].url.should.include('js/index.js')
+    coverageInfo[1].url.should.include('js/utils/doc_ready.js')
+    coverageInfo[2].url.should.include('js/models/record.js')
+    coverageInfo[3].url.should.include('js/views/record.js')
+  })
+
   it('maintains original url in output', () => {
     const fixture = require('./fixtures/http-es6-modules.json')
     const coverageInfo = OutputFiles(fixture).getTransformedCoverage()