Use single Stat snapshot in checkMinConns

jackc · claude · jackc · commit ab523919740a · 2026-03-21T15:56:51.000Z
Two separate Stat() calls could return inconsistent values for
TotalConns and IdleConns. Capture once for a consistent snapshot.

Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/pgxpool/pool.go b/pgxpool/pool.go
@@ -558,7 +558,8 @@ func (p *Pool) checkMinConns() error {
 	// off this check
 
 	// Create the number of connections needed to get to both minConns and minIdleConns
-	toCreate := max(p.minConns-p.Stat().TotalConns(), p.minIdleConns-p.Stat().IdleConns())
+	stat := p.Stat()
+	toCreate := max(p.minConns-stat.TotalConns(), p.minIdleConns-stat.IdleConns())
 	if toCreate > 0 {
 		return p.createIdleResources(context.Background(), int(toCreate))
 	}

Original file line number	Diff line number	Diff line change
`@@ -558,7 +558,8 @@ func (p *Pool) checkMinConns() error {`
`558`	`558`	`// off this check`
`559`	`559`
`560`	`560`	`// Create the number of connections needed to get to both minConns and minIdleConns`
`561`		`- toCreate := max(p.minConns-p.Stat().TotalConns(), p.minIdleConns-p.Stat().IdleConns())`
	`561`	`+ stat := p.Stat()`
	`562`	`+ toCreate := max(p.minConns-stat.TotalConns(), p.minIdleConns-stat.IdleConns())`
`562`	`563`	`if toCreate > 0 {`
`563`	`564`	`return p.createIdleResources(context.Background(), int(toCreate))`
`564`	`565`	`}`