Commit a962aa4
committed
Apply baseline-offset compensation to TextInput placeholder
The placeholder in RCTUITextField (single-line) and RCTUITextView
(multi-line) inherits the paragraph style from `defaultTextAttributes`,
so it suffers the same bottom-anchor misalignment as typed text when
`lineHeight > fontSize`. Apply the equivalent
`NSBaselineOffsetAttributeName` in `_placeholderTextAttributes` so the
placeholder renders at the same vertical position as typed text.
These backing views are shared between Paper and Fabric, so this also
fixes the placeholder on the old arch (where the existing fix in facebook#38359
only addressed typed text).
Also simplify the RN Tester example to a single-line + multi-line pair
at fontSize 16 / lineHeight 32 — enough to demonstrate the regression
and the fix for both control types.1 parent f864b61 commit a962aa4
3 files changed
Lines changed: 30 additions & 23 deletions
File tree
- packages
- react-native/Libraries/Text/TextInput
- Multiline
- Singleline
- rn-tester/js/examples/TextInput
Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
364 | 364 | | |
365 | 365 | | |
366 | 366 | | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
367 | 373 | | |
368 | 374 | | |
369 | 375 | | |
| |||
Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
169 | 169 | | |
170 | 170 | | |
171 | 171 | | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
172 | 178 | | |
173 | 179 | | |
174 | 180 | | |
| |||
Lines changed: 18 additions & 23 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1189 | 1189 | | |
1190 | 1190 | | |
1191 | 1191 | | |
1192 | | - | |
| 1192 | + | |
1193 | 1193 | | |
1194 | | - | |
1195 | | - | |
1196 | | - | |
1197 | | - | |
1198 | | - | |
1199 | | - | |
1200 | 1194 | | |
| 1195 | + | |
| 1196 | + | |
| 1197 | + | |
| 1198 | + | |
| 1199 | + | |
| 1200 | + | |
| 1201 | + | |
1201 | 1202 | | |
1202 | 1203 | | |
1203 | | - | |
1204 | | - | |
1205 | | - | |
1206 | | - | |
1207 | | - | |
1208 | | - | |
1209 | | - | |
1210 | | - | |
1211 | | - | |
1212 | | - | |
1213 | | - | |
1214 | | - | |
1215 | | - | |
1216 | | - | |
1217 | | - | |
1218 | | - | |
| 1204 | + | |
| 1205 | + | |
| 1206 | + | |
| 1207 | + | |
| 1208 | + | |
| 1209 | + | |
| 1210 | + | |
| 1211 | + | |
| 1212 | + | |
| 1213 | + | |
1219 | 1214 | | |
1220 | 1215 | | |
1221 | 1216 | | |
| |||
0 commit comments