Merge pull request #958 from nodejs/main

Create a new pull request by comparing changes across two branches

Author: GulajavaMinistudio

doc/api/inspector.md

@@ -74,6 +74,9 @@ session.on('inspectorNotification', (message) => console.log(message.method));
 // Debugger.resumed
 ```
 
+> **Caveat** Breakpoints with same-thread session is not recommended, see
+> [support of breakpoints][].
+
 It is also possible to subscribe only to notifications with specific method:
 
 #### Event: `<inspector-protocol-method>`;
@@ -98,6 +101,9 @@ session.on('Debugger.paused', ({ params }) => {
 // [ '/the/file/that/has/the/breakpoint.js:11:0' ]
 ```
 
+> **Caveat** Breakpoints with same-thread session is not recommended, see
+> [support of breakpoints][].
+
 #### `session.connect()`
 
 <!-- YAML
@@ -247,6 +253,9 @@ session.on('inspectorNotification', (message) => console.log(message.method));
 // Debugger.resumed
 ```
 
+> **Caveat** Breakpoints with same-thread session is not recommended, see
+> [support of breakpoints][].
+
 It is also possible to subscribe only to notifications with specific method:
 
 #### Event: `<inspector-protocol-method>`;
@@ -271,6 +280,9 @@ session.on('Debugger.paused', ({ params }) => {
 // [ '/the/file/that/has/the/breakpoint.js:11:0' ]
 ```
 
+> **Caveat** Breakpoints with same-thread session is not recommended, see
+> [support of breakpoints][].
+
 #### `session.connect()`
 
 <!-- YAML
@@ -476,10 +488,27 @@ Blocks until a client (existing or connected later) has sent
 
 An exception will be thrown if there is no active inspector.
 
+## Support of breakpoints
+
+The Chrome DevTools Protocol [`Debugger` domain][] allows an
+`inspector.Session` to attach to a program and set breakpoints to step through
+the codes.
+
+However, setting breakpoints with a same-thread `inspector.Session`, which is
+connected by [`session.connect()`][], should be avoided as the program being
+attached and paused is exactly the debugger itself. Instead, try connect to the
+main thread by [`session.connectToMainThread()`][] and set breakpoints in a
+worker thread, or connect with a [Debugger][] program over WebSocket
+connection.
+
 [CPU Profiler]: https://chromedevtools.github.io/devtools-protocol/v8/Profiler
 [Chrome DevTools Protocol Viewer]: https://chromedevtools.github.io/devtools-protocol/v8/
+[Debugger]: debugger.md
 [Heap Profiler]: https://chromedevtools.github.io/devtools-protocol/v8/HeapProfiler
 [`'Debugger.paused'`]: https://chromedevtools.github.io/devtools-protocol/v8/Debugger#event-paused
+[`Debugger` domain]: https://chromedevtools.github.io/devtools-protocol/v8/Debugger
 [`inspector.close()`]: #inspectorclose
 [`session.connect()`]: #sessionconnect
+[`session.connectToMainThread()`]: #sessionconnecttomainthread
 [security warning]: cli.md#warning-binding-inspector-to-a-public-ipport-combination-is-insecure
+[support of breakpoints]: #support-of-breakpoints

doc/contributing/security-release-process.md

@@ -124,7 +124,7 @@ out a better way, forward the email you receive to
 `oss-security@lists.openwall.com` as a CC.
 
 * [ ] Post in the [nodejs-social channel][]
-  in the OpenJS slack asking for amplication of the blog post.
+  in the OpenJS slack asking for amplification of the blog post.
 
   ```text
   Security release pre-alert:
@@ -184,7 +184,7 @@ out a better way, forward the email you receive to
   ```
 
 * [ ] Post in the [nodejs-social channel][]
-  in the OpenJS slack asking for amplication of the blog post.
+  in the OpenJS slack asking for amplification of the blog post.
   ```text
   Security release:
 

test/parallel/parallel.status

@@ -26,8 +26,6 @@ test-worker-nearheaplimit-deadlock: PASS, FLAKY
 [$system==linux]
 # https://github.com/nodejs/node/issues/39368
 test-domain-error-types: PASS,FLAKY
-# https://github.com/nodejs/node/issues/47420
-test-file-write-stream4: PASS,FLAKY
 # https://github.com/nodejs/node/issues/43465
 test-http-server-request-timeouts-mixed: PASS, FLAKY
 

tools/make-v8.sh

@@ -9,6 +9,11 @@ cd deps/v8 || exit
 find . -type d -name .git -print0 | xargs -0 rm -rf
 ../../tools/v8/fetch_deps.py .
 
+JOBS_ARG=
+if [ "${JOBS}" ]; then
+  JOBS_ARG="-j ${JOBS}"
+fi
+
 ARCH=$(arch)
 if [ "$ARCH" = "s390x" ] || [ "$ARCH" = "ppc64le" ]; then
   TARGET_ARCH=$ARCH
@@ -46,10 +51,10 @@ if [ "$ARCH" = "s390x" ] || [ "$ARCH" = "ppc64le" ]; then
   gcc --version
   export PKG_CONFIG_PATH=$BUILD_TOOLS/pkg-config
   gn gen -v "out.gn/$BUILD_ARCH_TYPE" --args="is_component_build=false is_debug=false use_goma=false goma_dir=\"None\" use_custom_libcxx=false v8_target_cpu=\"$TARGET_ARCH\" target_cpu=\"$TARGET_ARCH\" v8_enable_backtrace=true $CC_WRAPPER"
-  ninja -v -C "out.gn/$BUILD_ARCH_TYPE" d8 cctest inspector-test
+  ninja -v -C "out.gn/$BUILD_ARCH_TYPE" "${JOBS_ARG}" d8 cctest inspector-test
 else
   DEPOT_TOOLS_DIR="$(cd _depot_tools && pwd)"
   # shellcheck disable=SC2086
   PATH="$DEPOT_TOOLS_DIR":$PATH tools/dev/v8gen.py "$BUILD_ARCH_TYPE" --no-goma $V8_BUILD_OPTIONS
-  PATH="$DEPOT_TOOLS_DIR":$PATH ninja -C "out.gn/$BUILD_ARCH_TYPE/" d8 cctest inspector-test
+  PATH="$DEPOT_TOOLS_DIR":$PATH ninja -C "out.gn/$BUILD_ARCH_TYPE/" "${JOBS_ARG}" d8 cctest inspector-test
 fi