snapshots

Author: jayshrivastava

datafusion/physical-expr/src/expressions/dynamic_filters.rs

@@ -646,23 +646,15 @@ mod test {
             &filter_schema_1,
         )
         .unwrap();
-        let df1 = dynamic_filter_1
-            .as_any()
-            .downcast_ref::<DynamicFilterPhysicalExpr>()
-            .unwrap();
-        let current1 = df1.current().unwrap();
-        insta::assert_snapshot!(format!("{current1:?}"), @r#"BinaryExpr { left: Column { name: "a", index: 0 }, op: Eq, right: Literal { value: Int32(42), field: Field { name: "lit", data_type: Int32 } }, fail_on_overflow: false }"#);
+        let snap = dynamic_filter_1.snapshot().unwrap().unwrap();
+        insta::assert_snapshot!(format!("{snap:?}"), @r#"BinaryExpr { left: Column { name: "a", index: 0 }, op: Eq, right: Literal { value: Int32(42), field: Field { name: "lit", data_type: Int32 } }, fail_on_overflow: false }"#);
         let dynamic_filter_2 = reassign_expr_columns(
             Arc::clone(&dynamic_filter) as Arc<dyn PhysicalExpr>,
             &filter_schema_2,
         )
         .unwrap();
-        let df2 = dynamic_filter_2
-            .as_any()
-            .downcast_ref::<DynamicFilterPhysicalExpr>()
-            .unwrap();
-        let current2 = df2.current().unwrap();
-        insta::assert_snapshot!(format!("{current2:?}"), @r#"BinaryExpr { left: Column { name: "a", index: 1 }, op: Eq, right: Literal { value: Int32(42), field: Field { name: "lit", data_type: Int32 } }, fail_on_overflow: false }"#);
+        let snap = dynamic_filter_2.snapshot().unwrap().unwrap();
+        insta::assert_snapshot!(format!("{snap:?}"), @r#"BinaryExpr { left: Column { name: "a", index: 1 }, op: Eq, right: Literal { value: Int32(42), field: Field { name: "lit", data_type: Int32 } }, fail_on_overflow: false }"#);
         // Both filters allow evaluating the same expression
         let batch_1 = RecordBatch::try_new(
             Arc::clone(&filter_schema_1),