Skip to content

Add x access token functionality#309

Merged
Andrew-Chen-Wang merged 4 commits intojazzband:masterfrom
dgmouris:add-x-access-token-functionality
Oct 6, 2020
Merged

Add x access token functionality#309
Andrew-Chen-Wang merged 4 commits intojazzband:masterfrom
dgmouris:add-x-access-token-functionality

Conversation

@dgmouris
Copy link
Copy Markdown
Contributor

@dgmouris dgmouris commented Oct 1, 2020

Refers to Issue #204

Comment thread docs/settings.rst Outdated
Comment thread rest_framework_simplejwt/authentication.py Outdated
@dgmouris
Copy link
Copy Markdown
Contributor Author

dgmouris commented Oct 1, 2020

@Andrew-Chen-Wang This sounds like a better idea, not going to lie about it.

I'll update the PR shortly to reflect these changes.

Thank you for your review.

@dgmouris
Copy link
Copy Markdown
Contributor Author

dgmouris commented Oct 5, 2020

Hey @Andrew-Chen-Wang

Just made the changes requested on the review. Hopefully the documentation has the same feel as the rest of the documentation.

Let me know if you'd like any changes there, thanks again.

Copy link
Copy Markdown
Member

@Andrew-Chen-Wang Andrew-Chen-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @dgmouris !!!

@Andrew-Chen-Wang Andrew-Chen-Wang merged commit f511e0a into jazzband:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants