Make clear that need to add simple_jwt to installed apps#420
Merged
Andrew-Chen-Wang merged 3 commits intojazzband:masterfrom Jun 22, 2021
rencesar:docs-add-simple-jwt-installed-apps
Merged
Make clear that need to add simple_jwt to installed apps#420Andrew-Chen-Wang merged 3 commits intojazzband:masterfrom rencesar:docs-add-simple-jwt-installed-apps
Andrew-Chen-Wang merged 3 commits intojazzband:masterfrom
rencesar:docs-add-simple-jwt-installed-apps
Conversation
Andrew-Chen-Wang
requested changes
Jun 14, 2021
Member
Andrew-Chen-Wang
left a comment
Andrew-Chen-Wang
left a comment
There was a problem hiding this comment.
Thanks! I should've fixed this after #394 so sorry about that.
Comment on lines
+31
to
+36
| INSTALLED_APPS = [ | ||
| ... | ||
| 'rest_framework_simplejwt', | ||
| ... | ||
| ] | ||
|
|
Member
There was a problem hiding this comment.
This really shouldn't be here. Many people don't enable localization. Where you see "You can also include a route for Simple JWT’s TokenVerifyView", write some docs below that section dedicated for "adding localizations/translations" (add both words for searching sake in RTD).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just added on the documentation the necessity of adding
rest_framework_simplejwttoINSTALLED_APPS#419