Avoid blacklisting app migrations failing in projects with multiple databases#429
Merged
Andrew-Chen-Wang merged 2 commits intojazzband:masterfrom Jun 27, 2021
ghazi-git:master
Merged
Avoid blacklisting app migrations failing in projects with multiple databases#429Andrew-Chen-Wang merged 2 commits intojazzband:masterfrom ghazi-git:master
Andrew-Chen-Wang merged 2 commits intojazzband:masterfrom
ghazi-git:master
Conversation
…he blacklisting app will run with no issues in projects with multiple databases
…ling in projects with multiple databases
Andrew-Chen-Wang
approved these changes
Jun 27, 2021
Member
Andrew-Chen-Wang
left a comment
Andrew-Chen-Wang
left a comment
There was a problem hiding this comment.
Thanks for this fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #428
For tests, it didn't seem straight forward to update the relevant test
tests.test_token_blacklist.TestPopulateJtiHexMigration.test_jti_field_should_contain_uuid_hex_stringsgiven that all querysets are run against the default database (specifically the creation of theOutstandingTokenunderRefreshToken.for_user). So, the best way I found to test this change is to add a second test database. Before the fix, all existing tests fail because the migration of the second database fails. After the fix, all the tests pass.