Skip to content

Commit f2ef955

Browse files
authored
fix(android): dont pass "--disable-sync" (microsoft#38301)
1 parent 4a2ebe2 commit f2ef955

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

packages/playwright-core/src/server/android/android.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ export class AndroidDevice extends SdkObject {
287287
'--disable-fre',
288288
'--no-default-browser-check',
289289
`--remote-debugging-socket-name=${socketName}`,
290-
...chromiumSwitches(),
290+
...chromiumSwitches(undefined, undefined, true),
291291
...this._innerDefaultArgs(options)
292292
];
293293
return chromeArguments;

packages/playwright-core/src/server/chromium/chromiumSwitches.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ const disabledFeatures = (assistantMode?: boolean) => [
4747
assistantMode ? 'AutomationControlled' : '',
4848
].filter(Boolean);
4949

50-
export const chromiumSwitches = (assistantMode?: boolean, channel?: string) => [
50+
export const chromiumSwitches = (assistantMode?: boolean, channel?: string, android?: boolean) => [
5151
'--disable-field-trial-config', // https://source.chromium.org/chromium/chromium/src/+/main:testing/variations/README.md
5252
'--disable-background-networking',
5353
'--disable-background-timer-throttling',
@@ -90,5 +90,5 @@ export const chromiumSwitches = (assistantMode?: boolean, channel?: string) => [
9090
// Less annoying popups.
9191
'--disable-search-engine-choice-screen',
9292
// Prevents the "three dots" menu crash in IdentityManager::HasPrimaryAccount for ephemeral contexts.
93-
'--disable-sync',
93+
android ? '' : '--disable-sync',
9494
].filter(Boolean);

0 commit comments

Comments
 (0)