Skip to content

Commit dc5206e

Browse files
committed
docs(CONTRIBUTING.md): update required node versions [ci skip]
Node ^12.20 || >=14.13 is now required because there are MJS modules in the project that have named imports from CJS modules. Support for doing this was only added in 14.13.0 and backported to 12.20.0: nodejs/node#35249 (comment)
1 parent aa18da0 commit dc5206e

1 file changed

Lines changed: 20 additions & 17 deletions

File tree

CONTRIBUTING.md

Lines changed: 20 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,15 @@
11
---
2-
32
<p align="center" class="toc">
4-
<strong><a href="#setup">Setup</a></strong>
5-
|
6-
<strong><a href="#running-lintingtests">Running linting/tests</a></strong>
7-
|
8-
<strong><a href="#writing-tests">Writing tests</a></strong>
9-
|
10-
<strong><a href="#debugging-code">Debugging code</a></strong>
11-
|
12-
<strong><a href="#internals">Internals</a></strong>
3+
<strong><a href="#setup">Setup</a></strong>
4+
|
5+
<strong><a href="#running-lintingtests">Running linting/tests</a></strong>
6+
|
7+
<strong><a href="#writing-tests">Writing tests</a></strong>
8+
|
9+
<strong><a href="#debugging-code">Debugging code</a></strong>
10+
|
11+
<strong><a href="#internals">Internals</a></strong>
1312
</p>
14-
1513
---
1614

1715
# Contributing
@@ -39,14 +37,14 @@ Feel free to check out the `#discussion`/`#development` channels on our [Slack](
3937

4038
## Developing
4139

42-
*Node*: Check that Node is [installed](https://nodejs.org/en/download/) with version `^12.16 || >= 14`. You can check this with `node -v`.
40+
_Node_: Check that Node is [installed](https://nodejs.org/en/download/) with version `^12.20 || >= 14.13`. You can check this with `node -v`.
4341

44-
*Yarn*: Make sure that Yarn 1 is [installed](https://classic.yarnpkg.com/en/docs/install) with version >= `1.19.0`.
42+
_Yarn_: Make sure that Yarn 1 is [installed](https://classic.yarnpkg.com/en/docs/install) with version >= `1.19.0`.
4543

46-
*Make*: If you are running Windows 10, you'll need to do one of the following:
44+
_Make_: If you are running Windows 10, you'll need to do one of the following:
4745

48-
* Clone the repository and run the commands inside [WSL 2](https://docs.microsoft.com/en-us/windows/wsl/install-win10).
49-
* Install [Make for Windows](http://gnuwin32.sourceforge.net/packages/make.htm).
46+
- Clone the repository and run the commands inside [WSL 2](https://docs.microsoft.com/en-us/windows/wsl/install-win10).
47+
- Install [Make for Windows](http://gnuwin32.sourceforge.net/packages/make.htm).
5048

5149
### Setup
5250

@@ -224,7 +222,12 @@ Other than normal Babel options, `options.json` can contain other properties to
224222
```jsonc
225223
// options.json example
226224
{
227-
"plugins": [["@babel/plugin-proposal-object-rest-spread", { "useBuiltIns": "invalidOption" }]],
225+
"plugins": [
226+
[
227+
"@babel/plugin-proposal-object-rest-spread",
228+
{ "useBuiltIns": "invalidOption" }
229+
]
230+
],
228231
"throws": "@babel/plugin-proposal-object-rest-spread currently only accepts a boolean option for useBuiltIns (defaults to false)"
229232
}
230233
```

0 commit comments

Comments
 (0)