fix(prefer-importing-jest-globals): preserve as imports (#1753)

Author: G-Rath

src/rules/__tests__/prefer-importing-jest-globals.test.ts

@@ -104,6 +104,60 @@ ruleTester.run('prefer-importing-jest-globals', rule, {
         },
       ],
     },
+    {
+      code: dedent`
+        import { describe as context } from '@jest/globals';
+        context("suite", () => {
+          test("foo");
+          expect(true).toBeDefined();
+        })
+      `,
+      output: dedent`
+        import { describe as context, expect, test } from '@jest/globals';
+        context("suite", () => {
+          test("foo");
+          expect(true).toBeDefined();
+        })
+      `,
+      parserOptions: { sourceType: 'module' },
+      errors: [
+        {
+          endColumn: 7,
+          column: 3,
+          line: 3,
+          messageId: 'preferImportingJestGlobal',
+        },
+      ],
+    },
+    {
+      code: dedent`
+        import { describe as context } from '@jest/globals';
+        describe("something", () => {
+          context("suite", () => {
+            test("foo");
+            expect(true).toBeDefined();
+          })
+        })
+      `,
+      output: dedent`
+        import { describe, describe as context, expect, test } from '@jest/globals';
+        describe("something", () => {
+          context("suite", () => {
+            test("foo");
+            expect(true).toBeDefined();
+          })
+        })
+      `,
+      parserOptions: { sourceType: 'module' },
+      errors: [
+        {
+          endColumn: 9,
+          column: 1,
+          line: 2,
+          messageId: 'preferImportingJestGlobal',
+        },
+      ],
+    },
     {
       code: dedent`
         jest.useFakeTimers();

src/rules/prefer-importing-jest-globals.ts

@@ -120,7 +120,14 @@ export default createRule({
                   specifier.type === AST_NODE_TYPES.ImportSpecifier &&
                   specifier.imported?.name
                 ) {
-                  functionsToImport.add(specifier.imported.name);
+                  let importName = specifier.imported.name;
+                  const local = getAccessorValue(specifier.local);
+
+                  if (local !== importName) {
+                    importName = `${importName} as ${local}`;
+                  }
+
+                  functionsToImport.add(importName);
                 }
 
                 if (specifier.type === AST_NODE_TYPES.ImportDefaultSpecifier) {