fix(consistent-test-it): false positives inside describe.each#782
Merged
G-Rath merged 1 commit intojest-community:mainfrom Mar 7, 2021
Merged
fix(consistent-test-it): false positives inside describe.each#782G-Rath merged 1 commit intojest-community:mainfrom
G-Rath merged 1 commit intojest-community:mainfrom
Conversation
G-Rath
pushed a commit
that referenced
this pull request
Mar 7, 2021
Collaborator
|
The title merged in to be greater than 100 chars - I've forcely re-worded it on main to be |
Collaborator
|
ugh seems the forces are coming together to prevent this one from being released: |
Collaborator
|
@SimenB I think this is because of #781 - in the past it doesn't look like husky/commitlint would run against the commits made by semantic-release. |
github-actions Bot
pushed a commit
that referenced
this pull request
Mar 7, 2021
## [24.1.8](v24.1.7...v24.1.8) (2021-03-07) ### Bug Fixes * **consistent-test-it:** support `it.each` in `describe.each` ([#782](#782)) ([0014da0](0014da0))
This was referenced Mar 8, 2021
Closed
Closed
This was referenced Mar 15, 2021
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this PR added false positive ESLing errors where
testinsidedescribe.eachwas actually thought to beitinsidedescribe.each. (and the other way around) - see failing tests.The bug exists on the last release (
24.1.7) but was not present before.The fix was in the
isDescribeandisTestCasehelpers, which ignored the.eachversion with templates.