add tests

Author: snitin315

e2e/__tests__/__snapshots__/failures.test.ts.snap

@@ -254,6 +254,13 @@ FAIL __tests__/duringTests.test.js
       at Object.test (__tests__/duringTests.test.js:45:1)
 `;
 
+exports[`not throwing Error objects 6`] = `
+FAIL __tests__/throwObjectWithStackProp.test.js
+  ● Test suite failed to run
+
+    42
+`;
+
 exports[`works with assertions in separate files 1`] = `
 FAIL __tests__/testMacro.test.js
   ✕ use some imported macro to make assertion

e2e/__tests__/failures.test.ts

@@ -51,6 +51,8 @@ test('not throwing Error objects', () => {
   }
 
   expect(wrap(cleanStderr(stderr))).toMatchSnapshot();
+  stderr = runJest(dir, ['throwObjectWithStackProp.test.js']).stderr;
+  expect(wrap(cleanStderr(stderr))).toMatchSnapshot();
 });
 
 test('works with node assert', () => {

e2e/failures/__tests__/throwObjectWithStackProp.test.js

@@ -0,0 +1,11 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+'use strict';
+
+// eslint-disable-next-line no-throw-literal
+throw {stack: 42};

packages/jest-jasmine2/src/__tests__/__snapshots__/expectationResultFactory.test.ts.snap

@@ -2,7 +2,7 @@
 
 exports[`expectationResultFactory returns the result if failed (with \`error.stack\` not as a string). 1`] = `
 "thrown: Object {
-  \\"stack\\": Array [],
+  \\"stack\\": 42,
 }"
 `;
 

packages/jest-jasmine2/src/__tests__/expectationResultFactory.test.ts

@@ -82,7 +82,7 @@ describe('expectationResultFactory', () => {
   it('returns the result if failed (with `error.stack` not as a string).', () => {
     const options = {
       actual: 'Fail',
-      error: {stack: []},
+      error: {stack: 42},
       expected: 'Pass',
       matcherName: 'testMatcher',
       passed: false,

packages/jest-message-util/src/index.ts

@@ -380,7 +380,7 @@ const removeBlankErrorLine = (str: string) =>
 // Error object, so we have to regexp out the message from the stack string
 // to format it.
 export const separateMessageFromStack = (
-  content: string,
+  content: unknown,
 ): {message: string; stack: string} => {
   if (!content) {
     return {message: '', stack: ''};
@@ -390,9 +390,8 @@ export const separateMessageFromStack = (
   // (maybe it's a code frame instead), just the first non-empty line.
   // If the error is a plain "Error:" instead of a SyntaxError or TypeError we
   // remove the prefix from the message because it is generally not useful.
-  const messageMatch = content.match(
-    /^(?:Error: )?([\s\S]*?(?=\n\s*at\s.*:\d*:\d*)|\s*.*)([\s\S]*)$/,
-  );
+  const ERROR_REGEXP = /^(?:Error: )?([\s\S]*?(?=\n\s*at\s.*:\d*:\d*)|\s*.*)([\s\S]*)$/;
+  const messageMatch = typeof content !== 'string' ? `${content}`.match(ERROR_REGEXP) : content.match(ERROR_REGEXP);
   if (!messageMatch) {
     // For typescript
     throw new Error('If you hit this error, the regex above is buggy.');