Skip to content

Commit b0fe627

Browse files
committed
Revert "Just add a message at the bottom instead of replacing it"
This reverts commit 3d726d5.
1 parent 3d726d5 commit b0fe627

2 files changed

Lines changed: 8 additions & 32 deletions

File tree

packages/jest-matchers/src/__tests__/__snapshots__/matchers.test.js.snap

Lines changed: 3 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -232,27 +232,13 @@ Received:
232232
exports[`.toBe() fails for: [] and [] 1`] = `
233233
"<dim>expect(<red>received</><dim>).toBe(<green>expected</><dim>)
234234

235-
Expected value to be (using ===):
236-
<green>[]</>
237-
Received:
238-
<red>[]</>
239-
240-
Difference:
241-
242-
<dim>Compared values have no visual difference. <dim>Looks like you wanted to test for object/array equality with strict \`toBe\` matcher. You probably need to use \`toEqual\` instead."
235+
Looks like you wanted to test for object/array equity with strict \`toBe\` matcher. You probably need to use \`toEqual\` instead."
243236
`;
244237

245238
exports[`.toBe() fails for: {"a": 1} and {"a": 1} 1`] = `
246239
"<dim>expect(<red>received</><dim>).toBe(<green>expected</><dim>)
247240

248-
Expected value to be (using ===):
249-
<green>{\\"a\\": 1}</>
250-
Received:
251-
<red>{\\"a\\": 1}</>
252-
253-
Difference:
254-
255-
<dim>Compared values have no visual difference. <dim>Looks like you wanted to test for object/array equality with strict \`toBe\` matcher. You probably need to use \`toEqual\` instead."
241+
Looks like you wanted to test for object/array equity with strict \`toBe\` matcher. You probably need to use \`toEqual\` instead."
256242
`;
257243

258244
exports[`.toBe() fails for: {"a": 1} and {"a": 5} 1`] = `
@@ -277,14 +263,7 @@ Difference:
277263
exports[`.toBe() fails for: {} and {} 1`] = `
278264
"<dim>expect(<red>received</><dim>).toBe(<green>expected</><dim>)
279265

280-
Expected value to be (using ===):
281-
<green>{}</>
282-
Received:
283-
<red>{}</>
284-
285-
Difference:
286-
287-
<dim>Compared values have no visual difference. <dim>Looks like you wanted to test for object/array equality with strict \`toBe\` matcher. You probably need to use \`toEqual\` instead."
266+
Looks like you wanted to test for object/array equity with strict \`toBe\` matcher. You probably need to use \`toEqual\` instead."
288267
`;
289268

290269
exports[`.toBe() fails for: 1 and 2 1`] = `

packages/jest-matchers/src/matchers.js

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010

1111
import type {MatchersObject} from 'types/Matchers';
1212

13-
import chalk from 'chalk';
1413
import diff from 'jest-diff';
1514
import getType from 'jest-get-type';
1615
import {escapeStrForRegex} from 'jest-regex-util';
@@ -68,31 +67,29 @@ const matchers: MatchersObject = {
6867
`Received:\n` +
6968
` ${printReceived(received)}`
7069
: () => {
71-
let suggestToEqual;
72-
7370
if (
7471
getType(received) === getType(expected) &&
7572
(getType(received) === 'object' || getType(expected) === 'array') &&
7673
equals(received, expected, [iterableEquality])
7774
) {
78-
suggestToEqual = chalk.dim(
79-
'Looks like you wanted to test for object/array equality with strict `toBe` matcher. You probably need to use `toEqual` instead.',
75+
return (
76+
matcherHint('.toBe') +
77+
'\n\n' +
78+
'Looks like you wanted to test for object/array equity with strict `toBe` matcher. You probably need to use `toEqual` instead.'
8079
);
8180
}
8281

8382
const diffString = diff(expected, received, {
8483
expand: this.expand,
8584
});
86-
8785
return (
8886
matcherHint('.toBe') +
8987
'\n\n' +
9088
`Expected value to be (using ===):\n` +
9189
` ${printExpected(expected)}\n` +
9290
`Received:\n` +
9391
` ${printReceived(received)}` +
94-
(diffString ? `\n\nDifference:\n\n${diffString}` : '') +
95-
(suggestToEqual ? ` ${suggestToEqual}` : '')
92+
(diffString ? `\n\nDifference:\n\n${diffString}` : '')
9693
);
9794
};
9895

0 commit comments

Comments
 (0)