chore: run tsc and linting as GH action (#9223)

Author: SimenB

.circleci/config.yml

@@ -18,19 +18,6 @@ aliases:
 
 version: 2
 jobs:
-  lint-and-typecheck:
-    working_directory: ~/jest
-    docker:
-      - image: circleci/node:12
-    steps:
-      - checkout
-      - restore-cache: *restore-cache
-      - run: yarn --no-progress --frozen-lockfile
-      - save-cache: *save-cache
-      - run: yarn lint --format junit -o reports/junit/js-lint-results.xml && yarn lint-es5-build --format junit -o reports/junit/js-es5-lint-results.xml  && yarn lint:prettier:ci && yarn check-copyright-headers
-      - store_test_results:
-          path: reports/junit
-
   test-node-8:
     working_directory: ~/jest
     docker:
@@ -131,7 +118,6 @@ workflows:
   version: 2
   build-and-deploy:
     jobs:
-      - lint-and-typecheck
       - test-node-8
       - test-node-10
       - test-node-12

.github/workflows/nodejs.yml

@@ -0,0 +1,43 @@
+name: Node CI
+
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - '**'
+
+jobs:
+  lint-and-typecheck:
+    name: Running TypeScript compiler & ESLint
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v1
+      - name: Get yarn cache
+        id: yarn-cache
+        run: echo "::set-output name=dir::$(yarn cache dir)"
+      - uses: actions/cache@v1
+        with:
+          path: ${{ steps.yarn-cache.outputs.dir }}
+          key: ubuntu-latest-node-12.x-yarn-${{ hashFiles('**/yarn.lock') }}
+          restore-keys: |
+            ubuntu-latest-node-12.x-yarn-
+      - uses: actions/setup-node@v1
+        with:
+          node-version: 12.x
+      - name: install
+        run: yarn install-no-ts-build
+      - name: build
+        run: node scripts/build.js
+      - name: run tsc
+        run: yarn build:ts
+      - name: run eslint
+        run: yarn lint
+      - name: run eslint on browser builds
+        run: yarn lint-es5-build
+      - name: run prettier
+        run: yarn lint:prettier:ci
+      - name: check copyright headers
+        run: yarn check-copyright-headers

scripts/buildTs.js

@@ -12,7 +12,7 @@ const path = require('path');
 
 const chalk = require('chalk');
 const execa = require('execa');
-const {getPackages, adjustToTerminalWidth, OK} = require('./buildUtils');
+const {getPackages} = require('./buildUtils');
 
 const packages = getPackages();
 
@@ -33,13 +33,14 @@ const args = [
 ];
 
 console.log(chalk.inverse('Building TypeScript definition files'));
-process.stdout.write(adjustToTerminalWidth('Building\n'));
 
 try {
   execa.sync('node', args, {stdio: 'inherit'});
-  process.stdout.write(`${OK}\n`);
+  console.log('Successfully built TypeScript definition files');
+  console.log(
+    chalk.inverse.green('Successfully built TypeScript definition files')
+  );
 } catch (e) {
-  process.stdout.write('\n');
   console.error(
     chalk.inverse.red('Unable to build TypeScript definition files')
   );