Skip to content

docs: replace es2015 with env#5385

Merged
thymikee merged 2 commits intojestjs:masterfrom
kentcdodds:patch-4
Jan 24, 2018
Merged

docs: replace es2015 with env#5385
thymikee merged 2 commits intojestjs:masterfrom
kentcdodds:patch-4

Conversation

@kentcdodds
Copy link
Copy Markdown

@kentcdodds kentcdodds commented Jan 24, 2018

Because babel-preset-es2015 is deprecated and babel-preset-env is a drop-in replacement.

Summary

Replace es2015 with env because babel-preset-es2015 is deprecated and babel-preset-env is a drop-in replacement.

Test plan

N/A

docs: replace es2015 with env
5a680d8 
Because `babel-preset-es2015` is deprecated and `babel-preset-env` is a drop-in replacement.
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 24, 2018 •
edited
Loading

Codecov Report

Merging #5385 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5385   +/-   ##
=======================================
  Coverage   61.33%   61.33%           
=======================================
  Files         205      205           
  Lines        6924     6924           
  Branches        4        3    -1     
=======================================
  Hits         4247     4247           
  Misses       2676     2676           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79086ee...91f4fe7. Read the comment docs.

@thymikee
Copy link
Copy Markdown
Contributor

thymikee commented Jan 24, 2018

Awesome! Would you mind also replacing it in README.md? https://github.com/facebook/jest#using-babel

@kentcdodds
Copy link
Copy Markdown
Author

kentcdodds commented Jan 24, 2018

Sure thing!

@kentcdodds
Copy link
Copy Markdown
Author

kentcdodds commented Jan 24, 2018

Done 👍

thymikee
thymikee approved these changes Jan 24, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@kentcdodds
Copy link
Copy Markdown
Author

kentcdodds commented Jan 24, 2018

Note there are still some integration tests using that preset. Perhaps if I think of it later I'll open another PR for it 👍

@thymikee
Copy link
Copy Markdown
Contributor

thymikee commented Jan 24, 2018

Yup, noticed that, but it's unrelated to PR topic. Much appreciated!

@thymikee thymikee merged commit a10288f into jestjs:master Jan 24, 2018
@kentcdodds kentcdodds deleted the patch-4 branch January 24, 2018 13:59
@renovate renovate Bot mentioned this pull request Feb 14, 2018
Open
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 12, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thymikee thymikee thymikee approved these changes

Assignees

No one assigned

Labels

CLA Signed ✔️

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kentcdodds @codecov-io @thymikee @facebook-github-bot
⚡