chore: remove support for browser field in config#9943
Merged
cpojer merged 2 commits intojestjs:masterfrom May 2, 2020
Merged
Conversation
SimenB
force-pushed
the
remove-browser-field
branch
2 times, most recently
from
3775116 to
d992628
Compare
SimenB
force-pushed
the
remove-browser-field
branch
from
d992628 to
bbe793b
Compare
thymikee
approved these changes
May 1, 2020
Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #9943 +/- ##
=======================================
Coverage 64.23% 64.23%
=======================================
Files 292 292
Lines 12466 12466
Branches 3075 3076 +1
=======================================
Hits 8007 8007
- Misses 3810 3811 +1
+ Partials 649 648 -1
Continue to review full report at Codecov.
|
cpojer
reviewed
May 1, 2020
| resolved "https://registry.yarnpkg.com/resolve-url/-/resolve-url-0.2.1.tgz#2c637fe77c893afd2a663fe21aa9080068e2052a" | ||
| integrity sha1-LGN/53yJOv0qZj/iGqkIAGjiBSo= | ||
|
|
||
| resolve@1.1.7: |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This allows us to remove the dependency on
browser-resolve. As the added deprecation message states, people can specify it asresolverif they want to use it.Should make sure to specify the upgrade path in the blog post when we release Jest 26.
Test plan
Green CI? 😀 This removes a feature, so not much to test.