Implement nullable reference types.

Author: jhett12321

NWN.Toolbox/src/Core/Config/Config.cs

@@ -11,21 +11,21 @@ internal sealed class Config
     public int Version { get; set; } = 1;
 
     [Description("ChatCommands is a module that provides a system of implementing chat commands in C#. It automatically handles command argument parsing, help lists and more.")]
-    public ChatCommandConfig ChatCommands { get; set; } = new ChatCommandConfig();
+    public ChatCommandConfig? ChatCommands { get; set; } = new ChatCommandConfig();
 
     [Description("ServerRestart is a module that automatically shutdowns the server after a period of time. A custom start script, or service like docker is required to automatically start the server again after shutdown.")]
-    public ServerRestartConfig ServerRestart { get; set; } = new ServerRestartConfig();
+    public ServerRestartConfig? ServerRestart { get; set; } = new ServerRestartConfig();
 
     [Description("ToolboxWindows is a module that adds a number of utility windows and tools for improved DM functionality, server administration and more.")]
-    public WindowConfig ToolboxWindows { get; set; } = new WindowConfig();
+    public WindowConfig? ToolboxWindows { get; set; } = new WindowConfig();
 
     [Description("Permissions is a module that allows server admins to control what tools and features players/DMs can use by creating groups and assigning permissions.")]
-    public PermissionsConfig Permissions { get; set; } = new PermissionsConfig();
+    public PermissionsConfig? Permissions { get; set; } = new PermissionsConfig();
 
     [Description("VersionCheck is a module that defines client version requirements to connect to the server (e.g. for NUI).")]
-    public VersionCheckConfig VersionCheck { get; set; } = new VersionCheckConfig();
+    public VersionCheckConfig? VersionCheck { get; set; } = new VersionCheckConfig();
 
     [Description("Languages is a module that allows characters to speak in different languages.")]
-    public LanguageConfig Languages { get; set; } = new LanguageConfig();
+    public LanguageConfig? Languages { get; set; } = new LanguageConfig();
   }
 }

NWN.Toolbox/src/Core/Config/ConfigService.cs

@@ -57,6 +57,7 @@ public ConfigService(PluginStorageService pluginStorageService)
 
     public void SaveConfig<T>(string fileName, T instance)
     {
+      ArgumentNullException.ThrowIfNull(instance, nameof(instance));
       string yaml = serializer.Serialize(instance);
       File.WriteAllText(GetConfigPath(fileName), yaml);
     }

NWN.Toolbox/src/Core/Config/Features/ChatCommandConfig.cs

@@ -11,9 +11,9 @@ internal sealed class ChatCommandConfig : IFeatureConfig
     public bool Enabled { get; set; } = true;
 
     [Description("Character prefixes that define if a message is detected as a command.")]
-    public List<string> CommandPrefixes { get; set; } = new List<string> { "/" };
+    public List<string>? CommandPrefixes { get; set; } = new List<string> { "/" };
 
     [Description("A list of words/prefixes that are ignored by command processing. E.g. '/' ignores all usages of '//' if the command prefix is /.")]
-    public List<string> IgnoreCommands { get; set; } = new List<string> { "/" };
+    public List<string>? IgnoreCommands { get; set; } = new List<string> { "/" };
   }
 }

NWN.Toolbox/src/Core/Config/Features/FeatureConfigExtensions.cs

@@ -1,8 +1,10 @@
+using System.Diagnostics.CodeAnalysis;
+
 namespace Jorteck.Toolbox.Core
 {
   internal static class FeatureConfigExtensions
   {
-    public static bool IsEnabled(this IFeatureConfig config)
+    public static bool IsEnabled([NotNullWhen(true)] this IFeatureConfig? config)
     {
       return config != null && config.Enabled;
     }

NWN.Toolbox/src/Core/Config/Features/PermissionsConfig.cs

@@ -13,6 +13,6 @@ internal sealed class PermissionsConfig : IFeatureConfig
     public bool ChatCommandEnable { get; set; } = true;
 
     [Description("The base chat command name.")]
-    public string ChatCommand { get; set; } = "perms";
+    public string? ChatCommand { get; set; } = "perms";
   }
 }

NWN.Toolbox/src/Core/Config/Features/ServerRestartConfig.cs

@@ -17,18 +17,18 @@ internal sealed class ServerRestartConfig : IFeatureConfig
     public uint RestartTimeSecs { get; set; } = 44 * 60 * 60;
 
     [Description("Defines a restart schedule using a cron expression: https://crontab.guru/\n  # If defined, overrides restart_time_secs.")]
-    public string RestartTimeCron { get; set; } = "";
+    public string? RestartTimeCron { get; set; } = "";
 
     [Description("The periods at which restart timer warnings are broadcasted to all players.")]
-    public List<uint> RestartWarningSecs { get; set; } = new List<uint> { 0, 60, 300, 1800, 3600, 14400 };
+    public List<uint>? RestartWarningSecs { get; set; } = new List<uint> { 0, 60, 300, 1800, 3600, 14400 };
 
     [Description("The boot message shown to players when the server is restarting.")]
-    public string BootMessage { get; set; } = "The server is restarting.";
+    public string? BootMessage { get; set; } = "The server is restarting.";
 
     [Description("The warning message shown to players at each restart_warning_secs period.")]
-    public string WarnMessage { get; set; } = "The server will restart in <time>.";
+    public string? WarnMessage { get; set; } = "The server will restart in <time>.";
 
     [Description("The warning message shown to players when server restart is imminent.")]
-    public string WarnMessageNow { get; set; } = "The server is restarting now!";
+    public string? WarnMessageNow { get; set; } = "The server is restarting now!";
   }
 }

NWN.Toolbox/src/Core/Config/Features/VersionCheckConfig.cs

@@ -10,14 +10,14 @@ internal sealed class VersionCheckConfig : IFeatureConfig
     public bool Enabled { get; set; } = false;
 
     [Description("The minimum version for the server. Clients who are below the version will be kicked when they attempt to connect.")]
-    public Version MinimumVersion { get; set; } = new Version
+    public Version? MinimumVersion { get; set; } = new Version
     {
       MajorVersion = 8193,
       MinorVersion = 30,
     };
 
     [Description("The recommended version for the server. Clients who are below the recommended version will see a warning message after they connect to the server.")]
-    public Version RecommendedVersion { get; set; } = new Version
+    public Version? RecommendedVersion { get; set; } = new Version
     {
       MajorVersion = 8193,
       MinorVersion = 34,

NWN.Toolbox/src/Core/Config/Features/WindowConfig.cs

@@ -18,7 +18,7 @@ internal sealed class WindowConfig
     public ListMode ListMode { get; set; } = ListMode.Blacklist;
 
     [Description("The list of windows to use as the whitelist/blacklist. Dependant on list_mode.")]
-    public List<string> Windows { get; set; } = new List<string>();
+    public List<string>? Windows { get; set; } = new List<string>();
   }
 
   internal enum ListMode

NWN.Toolbox/src/Core/Data/DatabaseDesignFactory.cs

@@ -8,7 +8,7 @@ internal sealed class DatabaseDesignFactory : IDesignTimeDbContextFactory<Databa
   {
     public Database CreateDbContext(string[] args)
     {
-      string directoryPath = Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location);
+      string directoryPath = Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location)!;
       string path = Path.Combine(directoryPath!, "toolbox-design-data.db");
       return new Database($"Data Source={path}");
     }

NWN.Toolbox/src/Core/Data/Models/EncounterModel.cs

@@ -7,15 +7,15 @@ namespace Jorteck.Toolbox.Core
 {
   internal sealed class EncounterModel
   {
-    public string Name { get; set; }
+    public required string Name { get; set; }
 
-    public string Author { get; set; }
+    public required string Author { get; set; }
 
     public DateTime Created { get; set; }
 
     public DateTime Updated { get; set; }
 
-    public List<EncounterSpawn> Creatures { get; set; }
+    public List<EncounterSpawn>? Creatures { get; set; }
 
     public sealed class EncounterSpawn
     {
@@ -25,9 +25,9 @@ public sealed class EncounterSpawn
       public float LocalOffsetY { get; set; }
       public float LocalOffsetZ { get; set; }
 
-      public byte[] CreatureData { get; set; }
+      public required byte[]? CreatureData { get; set; }
 
-      public EncounterModel Encounter { get; set; }
+      public required EncounterModel Encounter { get; set; }
     }
   }