Fog storage valid subdomain check incorrect for s3

[zacclark]

https://github.com/jnicklas/carrierwave/blob/master/lib/carrierwave/storage/fog.rb#L256

The current regex allows dots in the fog_directory when using the subdomain style urls to AWS. However, the AWS wildcard ssl certificate won't work if the bucket name has a dot. While dots are valid in subdomains, breaking ssl seems to nullify the point of allowing them here.

[bensie]

The certificate won't work, but the fog_directory (bucket) is still technically valid.

Feel free to note this in the "known issues" section of the wiki, but since it only has to do with validity of the certificate and not the validity of the bucket itself, the burden of checking this shouldn't fall on CarrierWave.

[zacclark]

In making the assumption that links to AWS should use ssl (which is hardcoded into the url helper), CarrierWave is making a broken assumption about "good urls". If the gem is going to pick a default url at all it shouldn't pick one that is obviously going to cause problems, especially when the fog_directory validation is only used to pick a url scheme.

Why not make a simple change to the default to spare any user with "." bucket names from having to write custom config?

[bensie]

A URL that doesn't validate SSL is still a "good URL" -- it's well-formed and functional.

A pull request to improve the behavior here would be welcome, as long as it doesn't place restrictions on otherwise valid bucket names.

[zacclark]

Ok, would you consider switching to the other url scheme (s3.amazonaws.com/bucket) a "restriction"?

[bensie]

Not at all. I totally agree that the subdomain scheme is brittle.

[bensie]

You may be getting more into Fog territory with that though than CarrierWave.

[geemus]

@spyyddir - I tend to use the s3.amazonaws.com/bucket style where possible in fog for this very reason (it always works, whereas there are many exceptions to the valid subdomain). It seems there are a number of issues around this that can creep up with different regional endpoints, however, whereas the subdomain style I think may avoid this.

[mada41]

hi guys.
how about handle integration with S3 + Cloudflare ?
https://support.cloudflare.com/hc/en-us/articles/200168926-How-do-I-use-CloudFlare-with-Amazon-s-S3-Service-