Commit f508c02
John French
src: create a HandleScope in FinalizeCallback
Refs: nodejs/node-addon-api#832
Seems like FinalizeCallback needs to create a HandleScope
since it calls ObjectWrap::~ObjectWrap() which might need
to create a temporary Object handle here
https://github.com/nodejs/node-addon-api/blob/master/napi-inl.h#L3558
at Realm (https://github.com/realm/realm-js) we have crashes
with stacktrace at this location.
While fixed in core for later versions we still need for
older versions of Node.js
PR-URL: nodejs/node-addon-api#832
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Kevin Eady <kevin.c.eady@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>1 parent 5ff1acc commit f508c02
1 file changed
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3977 | 3977 | | |
3978 | 3978 | | |
3979 | 3979 | | |
| 3980 | + | |
3980 | 3981 | | |
3981 | 3982 | | |
3982 | 3983 | | |
| |||
0 commit comments