Skip to content

Refactor protocols, better documentation, more correct ASGI behaviour#108

Merged
jordaneremieff merged 2 commits intomasterfrom
fix-lifespan
May 15, 2020
Merged

Refactor protocols, better documentation, more correct ASGI behaviour#108
jordaneremieff merged 2 commits intomasterfrom
fix-lifespan

Conversation

@jordaneremieff
Copy link
Copy Markdown
Collaborator

Refs #107

  • Lifespan is refactored into a context manager and run in the handler.
  • The enable_lifespan parameter is now deprecated. Since I had this one included in many examples for a large period of time the warning will be displayed until 0.10.0.
  • Introduced lifespan parameter for settings lifespan using 'auto', 'on', 'off'.
  • A lot of code comments about the ASGI cycle behaviour to make it easier to understand the flow.
  • The WebSocket and Lifespan protocols are more compliant with the ASGI spec.

…r, move things around, better docstrings/comments, pytest.ini
@jordaneremieff jordaneremieff merged commit df70493 into master May 15, 2020
@jordaneremieff jordaneremieff deleted the fix-lifespan branch June 28, 2020 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant