Exclude tests from find_packages#200
Merged
jordaneremieff merged 1 commit intoKludex:mainfrom Aug 11, 2021
Merged
Conversation
Necessary after Kludex#170 added a `tests/__init__.py` file that lead `find_packages` to treat `tests`as a package dir, which will clobber `mangum` users' ability to import from a repo-local `tests` directory.
Collaborator
|
Thanks @bradsbrown! The pipelines are failing, but this seems related to a major release of a dependency unrelated to your changes. I'll merge this in and fix the pipeline issue later. |
khamaileon
pushed a commit
to khamaileon/mangum
that referenced
this pull request
Jan 13, 2024
Necessary after Kludex#170 added a `tests/__init__.py` file that lead `find_packages` to treat `tests`as a package dir, which will clobber `mangum` users' ability to import from a repo-local `tests` directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #194
Necessary after #170
added a
tests/__init__.pyfile that leadfind_packagesto treattestsas a package dir, which will clobbermangumusers' abilityto import from a repo-local
testsdirectory.