Skip to content

Fix resource update for 'awx_credential' #1

Merged
josh-silvas merged 2 commits intojosh-silvas:mainfrom
NikolayDupak:fix-credentials
Apr 6, 2024
Merged

Fix resource update for 'awx_credential' #1
josh-silvas merged 2 commits intojosh-silvas:mainfrom
NikolayDupak:fix-credentials

Conversation

@NikolayDupak
Copy link
Copy Markdown

There was bug with resource 'awx_credential' with field 'inputs'.
AWX credential has field 'inputs' and it's type string, but in the rest api documentation has type JSON.

Issue:
After apply terraform state for awx_credential with already created resources, failed because AWX api returned value for 'inputs' with type 'map[string]interface{}'.

Changed:

  • type for 'inputs' field, from string to map[string]interface{}
  • removed unmarshal for 'inputs' field

Fixed:

  • used correct return function in 'resourceCredentialUpdate', changed from 'resourceCredentialSCMRead' to 'resourceCredentialRead'

Copy link
Copy Markdown
Owner

@josh-silvas josh-silvas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, however, the documentation needs to be updated. Can you run make docs to update the documentation for this change and add to the PR?

@josh-silvas josh-silvas merged commit 9043e3f into josh-silvas:main Apr 6, 2024
@josh-silvas
Copy link
Copy Markdown
Owner

Thanks @NikolayDupak, releasing this as v1.0.8 shortly.

@josh-silvas
Copy link
Copy Markdown
Owner

josh-silvas pushed a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants