Get compute engine credential type id dynamically#12
Merged
josh-silvas merged 4 commits intojosh-silvas:mainfrom Sep 11, 2024
Merged
Conversation
josh-silvas
approved these changes
Sep 11, 2024
Owner
josh-silvas
left a comment
josh-silvas
left a comment
There was a problem hiding this comment.
Hrm, this is interesting. Either way, I think fetching by name makes sense. 👍
quentinleclerc
pushed a commit
that referenced
this pull request
May 2, 2025
Inventory can be `null` in AWX API responses. Before this change, these were always converted to `0` which resulted in invalid diffs during plan generation. Before:  After: 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Weirdly in my AWX setup the Google Compute Engine credential type does not have the same id that is hardcoded in the provider (two different installations).
I don't know if it's something that can happen for other or not. This PR fetches the ID by name instead. Which surely can move... but at least I'll work for every setup.