feat: Add import support for credential resources and fix related bugs#55
Merged
quentinleclerc merged 5 commits intojosh-silvas:mainfrom Mar 26, 2026
Merged
Conversation
quentinleclerc
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importerblock toawx_credential_machine,awx_credential_vault,awx_credential_container_registry,awx_credential_azure_key_vault, andawx_credential_google_compute_engineresources;awx_credential_azure_key_vault: credential type was hardcoded as 19 instead of being looked up by name — now usesGetCredentialTypeByName("Microsoft Azure Key Vault")like other credential resources;awx_credential_container_registry:verify_sslwas always reset to false after import because AWX omits the field when it's false — now only sets the value if the field is present in the API response;awx_credential_machine:ssh_public_key_datawas incorrectly usingsetSanitizedEncryptedCredential(for sensitive/encrypted fields) when it is a public, non-sensitive field — this caused a type assertion panic on importFields marked as sensitive (
vault_password,ssh_key_data,secret) will show a diff after import. This is expected behaviour — AWX never returns encrypted values via the API, so the user must set these values in their configuration after importing.