This repository was archived by the owner on Apr 22, 2023. It is now read-only.
fs: disallow overwrite F_OK/R_OK/W_OK/X_OK#9060
Closed
JacksonTian wants to merge 1 commit intonodejs:v0.12from
JacksonTian:disalow_overwriteten
Closed
fs: disallow overwrite F_OK/R_OK/W_OK/X_OK#9060JacksonTian wants to merge 1 commit intonodejs:v0.12from JacksonTian:disalow_overwriteten
JacksonTian wants to merge 1 commit intonodejs:v0.12from
JacksonTian:disalow_overwriteten
Conversation
change the fs.F_OK/R_OK/W_OK/X_OK out of fs.js will lead unexpect exception. make these properties readonly.
trevnorris
pushed a commit
that referenced
this pull request
Feb 11, 2015
Change the fs.F_OK/R_OK/W_OK/X_OK out of fs.js will lead unexpect exception. Make these properties readonly. PR-URL: #9060 [trev.norris@gmail.com test properties are read only] Signed-off-by: Trevor Norris <trev.norris@gmail.com>
|
Thanks. Landed w/ a test in 4823afc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.