fix: sanitize wing param, cross-platform paths, tighten test assertions

Addresses Copilot review feedback on MemPalace#659.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: jphein

mempalace/hooks_cli.py

@@ -133,7 +133,9 @@ def _wing_from_transcript_path(transcript_path: str) -> str:
         ~/.claude/projects/-home-<user>-Projects-<project>/session.jsonl
     We extract <project> as the wing name.  Falls back to "sessions".
     """
-    match = re.search(r"-Projects-([^/]+?)(?:/|$)", transcript_path)
+    # Normalize path separators for cross-platform (Windows backslashes)
+    normalized = transcript_path.replace("\\", "/")
+    match = re.search(r"-Projects-([^/]+?)(?:/|$)", normalized)
     if match:
         return match.group(1).lower().replace(" ", "_")
     return "sessions"

mempalace/mcp_server.py

@@ -554,7 +554,7 @@ def tool_diary_write(agent_name: str, entry: str, topic: str = "general", wing:
         return {"success": False, "error": str(e)}
 
     if wing:
-        wing = wing.lower().replace(" ", "_")
+        wing = sanitize_name(wing)
     else:
         wing = f"wing_{agent_name.lower().replace(' ', '_')}"
     room = "diary"
@@ -612,10 +612,20 @@ def tool_diary_read(agent_name: str, last_n: int = 10, wing: str = ""):
     """
     Read an agent's recent diary entries. Returns the last N entries
     in chronological order — the agent's personal journal.
+
+    When ``wing`` is provided, reads from that wing instead of the
+    agent's default ``wing_<agent_name>`` wing.  This lets hooks
+    direct diary reads to a project-specific wing derived from
+    the transcript path.
     """
-    if wing:
-        wing = wing.lower().replace(" ", "_")
-    else:
+    try:
+        agent_name = sanitize_name(agent_name, "agent_name")
+        if wing:
+            wing = sanitize_name(wing)
+    except ValueError as e:
+        return {"success": False, "error": str(e)}
+
+    if not wing:
         wing = f"wing_{agent_name.lower().replace(' ', '_')}"
     col = _get_collection()
     if not col:

tests/test_hooks_cli.py

@@ -15,6 +15,7 @@
     _maybe_auto_ingest,
     _parse_harness_input,
     _sanitize_session_id,
+    _wing_from_transcript_path,
     hook_stop,
     hook_session_start,
     hook_precompact,
@@ -170,6 +171,26 @@ def test_stop_hook_blocks_at_interval(tmp_path):
     )
     assert result["decision"] == "block"
     assert result["reason"].startswith(STOP_BLOCK_REASON)
+    # Default wing when transcript path doesn't match Claude Code pattern
+    assert "wing=sessions" in result["reason"]
+
+
+def test_stop_hook_derives_wing_from_transcript_path(tmp_path):
+    """When transcript path looks like a Claude Code path, wing is derived from it."""
+    project_dir = tmp_path / ".claude" / "projects" / "-home-jp-Projects-myproject"
+    project_dir.mkdir(parents=True)
+    transcript = project_dir / "session.jsonl"
+    _write_transcript(
+        transcript,
+        [{"message": {"role": "user", "content": f"msg {i}"}} for i in range(SAVE_INTERVAL)],
+    )
+    result = _capture_hook_output(
+        hook_stop,
+        {"session_id": "test", "stop_hook_active": False, "transcript_path": str(transcript)},
+        state_dir=tmp_path,
+    )
+    assert result["decision"] == "block"
+    assert "wing=myproject" in result["reason"]
 
 
 def test_stop_hook_tracks_save_point(tmp_path):
@@ -214,6 +235,28 @@ def test_precompact_always_blocks(tmp_path):
     assert result["reason"] == PRECOMPACT_BLOCK_REASON
 
 
+# --- _wing_from_transcript_path ---
+
+
+def test_wing_from_transcript_path_extracts_project():
+    path = "/home/jp/.claude/projects/-home-jp-Projects-memorypalace/session.jsonl"
+    assert _wing_from_transcript_path(path) == "memorypalace"
+
+
+def test_wing_from_transcript_path_fallback():
+    assert _wing_from_transcript_path("/some/random/path.jsonl") == "sessions"
+
+
+def test_wing_from_transcript_path_windows_backslashes():
+    path = "C:\\Users\\jp\\.claude\\projects\\-home-jp-Projects-myapp\\session.jsonl"
+    assert _wing_from_transcript_path(path) == "myapp"
+
+
+def test_wing_from_transcript_path_lowercases():
+    path = "/home/jp/.claude/projects/-home-jp-Projects-MyProject/session.jsonl"
+    assert _wing_from_transcript_path(path) == "myproject"
+
+
 # --- _log ---