feat(modules support): add node.js modules support to cli#360
Merged
kaosat-dev merged 13 commits intomasterfrom Mar 9, 2018
Merged
feat(modules support): add node.js modules support to cli#360kaosat-dev merged 13 commits intomasterfrom
kaosat-dev merged 13 commits intomasterfrom
Conversation
is built with node.js modules
to add module support * removed local test module (now moved to examples)
* renamed a few modules for more coherence with their contents * getParameterDefinitionsCLI => getParameterValuesFromParameters (still not good name...) * getParameterValues => getParameterValuesFromUIControls * split up scriptLoading into requireDesignFromModule & requireDesignFromString * added related helpers * updated imports
* added helpers for node module support for cli , desktop & co * .jscad extension support * utilities to find entry points from files/ folders * updated dependencies
Member
|
I just remembered something... UPPER CASE file extensions don’t work. For example, myfile.STL There are some programs out there that do this still. Otherwise, the code looks fine. I think some parts of the README could go on the WIKI. |
Contributor
Author
|
which file is that ? (in uppercase ?) feel free to copy & paste to the wiki of course :) but I like clear and self contained READMEs with all needed information |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for using designs defined as node.js modules (ie with require() & module.exports etc) as inputs to the command line