Merged
Conversation
…zers from io module
SimonClark
reviewed
Sep 14, 2020
|
|
||
| /* function to turn old style jscad code with implicit imports | ||
| into code with explicit exports/imports */ | ||
| // FIXME wouldn't a javascript error be better then 'hacking' the users code? |
Contributor
There was a problem hiding this comment.
Yes! And if there is a time to do this, it's now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes fix issues when drag-n-drop of exported JSON files, i.e. designs saved as JSON. There were issues with the handling of single files, as well as a missing deserializer for JSON files.
UNDERNEATH... I've been wanting to refactor how the deserializers were registered in the IO module. The following changes have been made:
Now, there's just one list which can change, adding or removing a deserializer for an external format.
All Submissions: