Skip to content

V2 : several fixes for modeling#705

Merged
SimonClark merged 11 commits intoV2from
v2-fixes-modeling
Oct 3, 2020
Merged

V2 : several fixes for modeling#705
SimonClark merged 11 commits intoV2from
v2-fixes-modeling

Conversation

@z3dev
Copy link
Copy Markdown
Member

@z3dev z3dev commented Oct 3, 2020

These changes fix several issues found in the modeling package.

  • fix(modeling): added startAngle and endAngle options to ellipse / circle, and expanded test cases
  • fix(modeling): corrected offset if segments are paralell, and expanded test cases
  • fix(modeling): allow geom2.fromPoints() to accept the same closing point as the first point, and expanded test cases
    • the SVG deserializer tests required changes as this change to geom2 corrected issues with duplicate points

In addition, the 'hoisting' of 'ava' and 'nyc' has been corrected. The bootstrap process is now exceedingly fast. 👍
Also, test and coverage scripts can be executed inside the individual packages. 👍

There's a fix for the remote proxy process as well, which was included to excellerate the review.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass tests?

Additional testing was performed with CLI and WEB UI.

@BarbourSmith
Copy link
Copy Markdown

I appreciated these changes. They fixed a bug I noticed. Thank you.

@z3dev z3dev deleted the v2-fixes-modeling branch October 27, 2020 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants