Skip to content

V2 : Fix core packaging#720

Merged
SimonClark merged 11 commits intoV2from
v2-fix-core
Oct 28, 2020
Merged

V2 : Fix core packaging#720
SimonClark merged 11 commits intoV2from
v2-fix-core

Conversation

@z3dev
Copy link
Copy Markdown
Member

@z3dev z3dev commented Oct 23, 2020

These changes correct the core package, and enhance the package into a true library.

  • source has been moved to 'src' directory
  • indexes have been created for each sub-part, i.e. code-evaluation, utils, etc.
  • packaging has been improved to meet NPM standards

NOTE: The core package was only repackaged. No restructuring of code was performed.

There are two areas of change in the core package:

  • rebuildGeometry has been changed; improving the documentation, and correcting default options
  • walkFileTree has been moved from the web package into the core package, as this is fundamental for other applications

In addition to the core package changes, the cli and the web packages were corrected to use the core package properly, i.e. require().

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass tests?

Copy link
Copy Markdown
Member Author

@z3dev z3dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes as expected. TIme for review.

z3dev added 2 commits October 23, 2020 16:52
Conflicts:
	packages/core/package.json
Copy link
Copy Markdown
Member Author

@z3dev z3dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes as expected. Time for a review.

@z3dev z3dev requested a review from SimonClark October 26, 2020 05:23
@SimonClark SimonClark merged commit e19c10c into V2 Oct 28, 2020
@z3dev z3dev deleted the v2-fix-core branch November 23, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants