Merged
Conversation
…library organization
…eneral use of JSCAD
z3dev
commented
Oct 23, 2020
Member
Author
z3dev
left a comment
There was a problem hiding this comment.
Changes as expected. TIme for review.
Conflicts: packages/core/package.json
z3dev
commented
Oct 26, 2020
Member
Author
z3dev
left a comment
There was a problem hiding this comment.
Changes as expected. Time for a review.
SimonClark
approved these changes
Oct 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes correct the core package, and enhance the package into a true library.
NOTE: The core package was only repackaged. No restructuring of code was performed.
There are two areas of change in the core package:
In addition to the core package changes, the cli and the web packages were corrected to use the core package properly, i.e. require().
All Submissions: